isdn: hisax: Fix pnp_irq's error checking for setup_niccy
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Thu, 16 Nov 2017 04:27:27 +0000 (09:57 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 16 Nov 2017 13:31:16 +0000 (22:31 +0900)
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hisax/niccy.c

index e4c33cfe3ef489f7a26eefcebdba625e039cb9d5..dfbcd2eaa81a3a6ebfb600418a68fbaa02c92e4a 100644 (file)
@@ -261,7 +261,7 @@ int setup_niccy(struct IsdnCard *card)
                        card->para[1] = pnp_port_start(pnp_d, 0);
                        card->para[2] = pnp_port_start(pnp_d, 1);
                        card->para[0] = pnp_irq(pnp_d, 0);
-                       if (!card->para[0] || !card->para[1] ||
+                       if (card->para[0] == -1 || !card->para[1] ||
                            !card->para[2]) {
                                printk(KERN_ERR "NiccyPnP:some resources are "
                                       "missing %ld/%lx/%lx\n",