scsi: lpfc: Fix irq raising in lpfc_sli_hba_down
authorJames Smart <jsmart2021@gmail.com>
Wed, 14 Aug 2019 23:56:42 +0000 (16:56 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 20 Aug 2019 02:41:09 +0000 (22:41 -0400)
The adapter reset path (lpfc_sli_hba_down) is taking/releasing a lock with
irq. But, the path is already under the hbalock which raised irq so it's
unnecessary.

Convert to simple lock/unlock.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_sli.c

index b453d10ef36ecba8ddd8d3e69033c3c259c216fb..7c4bca47496a818091565315568dc445fc388caf 100644 (file)
@@ -10808,9 +10808,9 @@ lpfc_sli_hba_down(struct lpfc_hba *phba)
                        pring = qp->pring;
                        if (!pring)
                                continue;
-                       spin_lock_irq(&pring->ring_lock);
+                       spin_lock(&pring->ring_lock);
                        list_splice_init(&pring->txq, &completions);
-                       spin_unlock_irq(&pring->ring_lock);
+                       spin_unlock(&pring->ring_lock);
                        if (pring == phba->sli4_hba.els_wq->pring) {
                                pring->flag |= LPFC_DEFERRED_RING_EVENT;
                                /* Set the lpfc data pending flag */