mei: don't clean control queues on notify request timeout
authorAlexander Usyskin <alexander.usyskin@intel.com>
Wed, 20 Apr 2016 15:03:54 +0000 (11:03 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 Apr 2016 21:08:08 +0000 (14:08 -0700)
Timeout on notify request is not a fatal condition, and actually
cleaning control queues will disrupt other control flows of the
same client.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/client.c

index 09f5280fa021f9f593cfd493075f463ba8c8a768..85ae11d410cc90d10c8390a224aff2b3dca666c6 100644 (file)
@@ -1337,12 +1337,8 @@ int mei_cl_notify_request(struct mei_cl *cl,
                        mei_secs_to_jiffies(MEI_CL_CONNECT_TIMEOUT));
        mutex_lock(&dev->device_lock);
 
-       if (cl->notify_en != request) {
-               mei_io_list_flush(&dev->ctrl_rd_list, cl);
-               mei_io_list_flush(&dev->ctrl_wr_list, cl);
-               if (!cl->status)
-                       cl->status = -EFAULT;
-       }
+       if (cl->notify_en != request && !cl->status)
+               cl->status = -EFAULT;
 
        rets = cl->status;