i40evf: Use net_device_stats from struct net_device
authorTobias Klauser <tklauser@distanz.ch>
Thu, 6 Apr 2017 06:46:28 +0000 (08:46 +0200)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 19 Apr 2017 23:31:34 +0000 (16:31 -0700)
Instead of using a private copy of struct net_device_stats in
struct i40evf_adapter, use stats from struct net_device. Also remove the
now unnecessary .ndo_get_stats function.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40evf/i40evf.h
drivers/net/ethernet/intel/i40evf/i40evf_main.c
drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c

index 35ded19e9cc207a43075ff0b549b52b2d5f22f2f..7bbd11abed08da63153a2b1038a36c998f3344e5 100644 (file)
@@ -252,7 +252,6 @@ struct i40evf_adapter {
        /* OS defined structs */
        struct net_device *netdev;
        struct pci_dev *pdev;
-       struct net_device_stats net_stats;
 
        struct i40e_hw hw; /* defined in i40e_type.h */
 
index 12a930e879af3d47f30f238800fc57d228e1e9dd..671913c74bf8a348800dda13ecddeb5d84a1b6e4 100644 (file)
@@ -2242,21 +2242,6 @@ static int i40evf_close(struct net_device *netdev)
        return 0;
 }
 
-/**
- * i40evf_get_stats - Get System Network Statistics
- * @netdev: network interface device structure
- *
- * Returns the address of the device statistics structure.
- * The statistics are actually updated from the timer callback.
- **/
-static struct net_device_stats *i40evf_get_stats(struct net_device *netdev)
-{
-       struct i40evf_adapter *adapter = netdev_priv(netdev);
-
-       /* only return the current stats */
-       return &adapter->net_stats;
-}
-
 /**
  * i40evf_change_mtu - Change the Maximum Transfer Unit
  * @netdev: network interface device structure
@@ -2363,7 +2348,6 @@ static const struct net_device_ops i40evf_netdev_ops = {
        .ndo_open               = i40evf_open,
        .ndo_stop               = i40evf_close,
        .ndo_start_xmit         = i40evf_xmit_frame,
-       .ndo_get_stats          = i40evf_get_stats,
        .ndo_set_rx_mode        = i40evf_set_rx_mode,
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_set_mac_address    = i40evf_set_mac,
index 3bccfbb1db14b4f2d03e49a2a0d17032892d15bb..deb2cb8dac6b2051ed99a05b11076fc561e141c0 100644 (file)
@@ -960,17 +960,17 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,
        case I40E_VIRTCHNL_OP_GET_STATS: {
                struct i40e_eth_stats *stats =
                        (struct i40e_eth_stats *)msg;
-               adapter->net_stats.rx_packets = stats->rx_unicast +
-                                                stats->rx_multicast +
-                                                stats->rx_broadcast;
-               adapter->net_stats.tx_packets = stats->tx_unicast +
-                                                stats->tx_multicast +
-                                                stats->tx_broadcast;
-               adapter->net_stats.rx_bytes = stats->rx_bytes;
-               adapter->net_stats.tx_bytes = stats->tx_bytes;
-               adapter->net_stats.tx_errors = stats->tx_errors;
-               adapter->net_stats.rx_dropped = stats->rx_discards;
-               adapter->net_stats.tx_dropped = stats->tx_discards;
+               netdev->stats.rx_packets = stats->rx_unicast +
+                                          stats->rx_multicast +
+                                          stats->rx_broadcast;
+               netdev->stats.tx_packets = stats->tx_unicast +
+                                          stats->tx_multicast +
+                                          stats->tx_broadcast;
+               netdev->stats.rx_bytes = stats->rx_bytes;
+               netdev->stats.tx_bytes = stats->tx_bytes;
+               netdev->stats.tx_errors = stats->tx_errors;
+               netdev->stats.rx_dropped = stats->rx_discards;
+               netdev->stats.tx_dropped = stats->tx_discards;
                adapter->current_stats = *stats;
                }
                break;