pinctrl/amd: Configure GPIO register using BIOS settings
authorAgrawal, Nitesh-kumar <Nitesh-kumar.Agrawal@amd.com>
Wed, 31 Aug 2016 08:50:49 +0000 (08:50 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 7 Sep 2016 19:48:16 +0000 (21:48 +0200)
In the function amd_gpio_irq_set_type, use the settings provided by
the BIOS,when the LevelTrig is Edge and activeLevel is HIGH, to configure
the GPIO registers. Ignore the settings from client.

Reviewed-by: Pankaj Sen <Pankaj.Sen@amd.com>
Signed-off-by:Nitesh Kumar Agrawal <Nitesh-kumar.Agrawal@amd.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-amd.c

index 634b4d30eefb1e3c14c4ed6243ca3382fc4f5b66..962746e6ab0435b15e86c29aef675f2e79aaaed6 100644 (file)
@@ -403,12 +403,27 @@ static int amd_gpio_irq_set_type(struct irq_data *d, unsigned int type)
        int ret = 0;
        u32 pin_reg;
        unsigned long flags;
+       u32 level_trig;
+       u32 active_level;
        struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
        struct amd_gpio *gpio_dev = gpiochip_get_data(gc);
 
        spin_lock_irqsave(&gpio_dev->lock, flags);
        pin_reg = readl(gpio_dev->base + (d->hwirq)*4);
 
+       /*
+        * When level_trig is set EDGE and active_level is set HIGH in BIOS
+        * default settings, ignore incoming settings from client and use
+        * BIOS settings to configure GPIO register.
+        */
+       level_trig = pin_reg & (LEVEL_TRIGGER << LEVEL_TRIG_OFF);
+       active_level = pin_reg & (ACTIVE_LEVEL_MASK << ACTIVE_LEVEL_OFF);
+
+       if((!level_trig) &&
+          ((active_level >> ACTIVE_LEVEL_OFF) == ACTIVE_HIGH)) {
+               type = IRQ_TYPE_EDGE_FALLING;
+       }
+
        switch (type & IRQ_TYPE_SENSE_MASK) {
        case IRQ_TYPE_EDGE_RISING:
                pin_reg &= ~BIT(LEVEL_TRIG_OFF);