ASoC: soc-core: initialize list at one place
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tue, 20 Aug 2019 05:05:20 +0000 (14:05 +0900)
committerMark Brown <broonie@kernel.org>
Thu, 22 Aug 2019 17:35:03 +0000 (18:35 +0100)
Initialize component related list at random place is very difficult
to read. This patch initialize it at snd_soc_component_initialize().

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/87y2zozazp.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-core.c

index 1a17cb1bc03b27feb62ca23373fdcfd12a1c4999..0af83963289f3dae0725c770967ae8e7a924a292 100644 (file)
@@ -1272,7 +1272,6 @@ static int soc_probe_component(struct snd_soc_card *card,
 
        component->card = card;
        dapm->card = card;
-       INIT_LIST_HEAD(&component->card_list);
        INIT_LIST_HEAD(&dapm->list);
        soc_set_name_prefix(card, component);
 
@@ -2648,6 +2647,8 @@ static int snd_soc_component_initialize(struct snd_soc_component *component,
        struct snd_soc_dapm_context *dapm;
 
        INIT_LIST_HEAD(&component->dai_list);
+       INIT_LIST_HEAD(&component->dobj_list);
+       INIT_LIST_HEAD(&component->card_list);
        mutex_init(&component->io_mutex);
 
        component->name = fmt_single_name(dev, &component->id);
@@ -2733,7 +2734,6 @@ static void snd_soc_component_add(struct snd_soc_component *component)
 
        /* see for_each_component */
        list_add(&component->list, &component_list);
-       INIT_LIST_HEAD(&component->dobj_list);
 
        mutex_unlock(&client_mutex);
 }