drm/amdgpu: stop pipelining VM PDs/PTs moves
authorChristian König <christian.koenig@amd.com>
Tue, 11 Sep 2018 07:30:46 +0000 (09:30 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 19 Sep 2018 17:38:17 +0000 (12:38 -0500)
We are going to need this for recoverable page fault handling and it
makes shadow handling during GPU reset much more easier.

Signed-off-by: Christian König <christian.koenig@amd.com>
Acked-by: Junwei Zhang <Jerry.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

index c1387efc0c91b8ddc3dfac4d69bc74c5541c14e6..9436994bc406bd66abb4c088765ab6976aa00834 100644 (file)
@@ -1366,7 +1366,7 @@ u64 amdgpu_bo_gpu_offset(struct amdgpu_bo *bo)
 {
        WARN_ON_ONCE(bo->tbo.mem.mem_type == TTM_PL_SYSTEM);
        WARN_ON_ONCE(!ww_mutex_is_locked(&bo->tbo.resv->lock) &&
-                    !bo->pin_count);
+                    !bo->pin_count && bo->tbo.type != ttm_bo_type_kernel);
        WARN_ON_ONCE(bo->tbo.mem.start == AMDGPU_BO_INVALID_OFFSET);
        WARN_ON_ONCE(bo->tbo.mem.mem_type == TTM_PL_VRAM &&
                     !(bo->flags & AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS));
index 5da87ec67c641c0426399fe1f7a7c141ddcc80ce..d619108736271cd9664a590fd0d9189f081aa79e 100644 (file)
@@ -532,7 +532,11 @@ static int amdgpu_move_blit(struct ttm_buffer_object *bo,
        if (r)
                goto error;
 
-       r = ttm_bo_pipeline_move(bo, fence, evict, new_mem);
+       /* Always block for VM page tables before committing the new location */
+       if (bo->type == ttm_bo_type_kernel)
+               r = ttm_bo_move_accel_cleanup(bo, fence, true, new_mem);
+       else
+               r = ttm_bo_pipeline_move(bo, fence, evict, new_mem);
        dma_fence_put(fence);
        return r;