msm: adreno: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Jun 2019 12:22:56 +0000 (14:22 +0200)
committerRob Clark <robdclark@chromium.org>
Tue, 18 Jun 2019 20:37:19 +0000 (13:37 -0700)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Jordan Crouse <jcrouse@codeaurora.org>
Cc: Mamta Shukla <mamtashukla555@gmail.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/adreno/a5xx_debugfs.c

index d9af3aff690f1613f2ca4a65328683b6a8a845f2..cb8dfc970ec30e0154826ca4ab4259edd3d8ef9c 100644 (file)
@@ -158,7 +158,6 @@ DEFINE_SIMPLE_ATTRIBUTE(reset_fops, NULL, reset_set, "%llx\n");
 int a5xx_debugfs_init(struct msm_gpu *gpu, struct drm_minor *minor)
 {
        struct drm_device *dev;
-       struct dentry *ent;
        int ret;
 
        if (!minor)
@@ -175,11 +174,8 @@ int a5xx_debugfs_init(struct msm_gpu *gpu, struct drm_minor *minor)
                return ret;
        }
 
-       ent = debugfs_create_file("reset", S_IWUGO,
-               minor->debugfs_root,
-               dev, &reset_fops);
-       if (!ent)
-               return -ENOMEM;
+       debugfs_create_file("reset", S_IWUGO, minor->debugfs_root, dev,
+                           &reset_fops);
 
        return 0;
 }