staging: fsl-dpaa2/ethsw: remove debug message
authorIoana Ciornei <ioana.ciornei@nxp.com>
Tue, 13 Aug 2019 12:43:01 +0000 (15:43 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2019 14:46:25 +0000 (16:46 +0200)
Since ethtool will be loud enough if the .set_link_ksettings() callback
fails, remove the debug messages which do not add additional
information.

Reported-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Link: https://lore.kernel.org/r/1565700187-16048-5-git-send-email-ioana.ciornei@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c

index 95e9f10969991f0d56b47601f4311dd8d83ebb7c..12e33a3a1bf15b92f4c7633fa2fb23b67bd1dd7d 100644 (file)
@@ -91,8 +91,6 @@ ethsw_set_link_ksettings(struct net_device *netdev,
        struct dpsw_link_cfg cfg = {0};
        int err = 0;
 
-       netdev_dbg(netdev, "Setting link parameters...");
-
        /* Due to a temporary MC limitation, the DPSW port must be down
         * in order to be able to change link settings. Taking steps to let
         * the user know that.
@@ -116,11 +114,6 @@ ethsw_set_link_ksettings(struct net_device *netdev,
                                   port_priv->ethsw_data->dpsw_handle,
                                   port_priv->idx,
                                   &cfg);
-       if (err)
-               /* ethtool will be loud enough if we return an error; no point
-                * in putting our own error message on the console by default
-                */
-               netdev_dbg(netdev, "ERROR %d setting link cfg", err);
 
        return err;
 }