r8169: fix sporadic transmit timeout issue
authorHeiner Kallweit <hkallweit1@gmail.com>
Mon, 12 Aug 2019 18:47:40 +0000 (20:47 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 14 Aug 2019 16:53:40 +0000 (12:53 -0400)
Holger reported sporadic transmit timeouts and it turned out that one
path misses ringing the doorbell. Fix was suggested by Eric.

Fixes: ef14358546b1 ("r8169: make use of xmit_more")
Suggested-by: Eric Dumazet <edumazet@google.com>
Tested-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169_main.c

index a4233ace21ca1d00b637b83d3270d04c674ad2fe..34d072f0c895305bb0085925702a7eb2a91d4bbc 100644 (file)
@@ -5681,6 +5681,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
                 */
                smp_wmb();
                netif_stop_queue(dev);
+               door_bell = true;
        }
 
        if (door_bell)