atm: lanai: set error code when ioremap fails
authorPan Bian <bianpan2016@163.com>
Sat, 3 Dec 2016 12:25:45 +0000 (20:25 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Dec 2016 18:27:33 +0000 (13:27 -0500)
In function lanai_dev_open(), when the call to ioremap() fails, the
value of return variable result is 0. 0 means no error in this context.
This patch fixes the bug, assigning "-ENOMEM" to result when ioremap()
returns a NULL pointer.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188791

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/lanai.c

index ce43ae3e87b3513245cf5b322d5a4b4984ec9dfa..445505d9ea07187902ed95c6ae121591b23cef5c 100644 (file)
@@ -2143,6 +2143,7 @@ static int lanai_dev_open(struct atm_dev *atmdev)
        lanai->base = (bus_addr_t) ioremap(raw_base, LANAI_MAPPING_SIZE);
        if (lanai->base == NULL) {
                printk(KERN_ERR DEV_LABEL ": couldn't remap I/O space\n");
+               result = -ENOMEM;
                goto error_pci;
        }
        /* 3.3: Reset lanai and PHY */