base-files: use get_mac_binary() in mtd_get_mac_binary_ubi()
authorAdrian Schmutzler <freifunk@adrianschmutzler.de>
Thu, 5 Sep 2019 11:29:37 +0000 (13:29 +0200)
committerDavid Bauer <mail@david-bauer.net>
Thu, 5 Sep 2019 18:42:08 +0000 (20:42 +0200)
The actual retrieval of the MAC address in mtd_get_mac_binary_ubi()
is the same as in get_mac_binary(). Thus, use the latter function
in the former to reduce duplicate code.

This will also allow to benefit from the enhanced path check there
and bring mtd_get_mac_binary_ubi() more in line with the similar
mtd_get_mac_binary().

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
package/base-files/files/lib/functions/system.sh

index 2a43d18d33d7bb1bfa5b5c4c43f03f3bf0feb657..5084c0052babdf3d9078b1c3058100e3aa6931ba 100644 (file)
@@ -79,12 +79,7 @@ mtd_get_mac_binary_ubi() {
        local ubidev=$(nand_find_ubi $CI_UBIPART)
        local part=$(nand_find_volume $ubidev $1)
 
-       if [ -z "$part" ]; then
-               echo "mtd_get_mac_binary: ubi volume $mtdname not found!" >&2
-               return
-       fi
-
-       hexdump -v -n 6 -s $offset -e '5/1 "%02x:" 1/1 "%02x"' /dev/$part 2>/dev/null
+       get_mac_binary "/dev/$part" "$offset"
 }
 
 mtd_get_part_size() {