Staging: rtl8192e: Fix incorrect type in assignment in rtl819x_BAProc.c
authorRashika Kheria <rashika.kheria@gmail.com>
Fri, 8 Nov 2013 12:56:20 +0000 (18:26 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 Nov 2013 20:02:22 +0000 (12:02 -0800)
This patch fixes the following Sparse warnings in
rtl819x_BAProc.c-

drivers/staging/rtl8192e/rtl819x_BAProc.c:118:21: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:118:21:    expected   unsigned short [unsigned] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:118:21:    got restricted __le16 [usertype] <noident>

drivers/staging/rtl8192e/rtl819x_BAProc.c:122:13: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:122:13:    expected unsigned short [unsigned] [addressable] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:122:13:    got restricted __le16 [usertype] <noident>

drivers/staging/rtl8192e/rtl819x_BAProc.c:125:13: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:125:13:    expected unsigned short [unsigned] [addressable] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:125:13:    got restricted __le16 [usertype] <noident>

drivers/staging/rtl8192e/rtl819x_BAProc.c:181:13: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:181:13:    expected unsigned short [unsigned] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:181:13:    got restricted __le16 [usertype] <noident>

drivers/staging/rtl8192e/rtl819x_BAProc.c:184:13: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:184:13:    expected unsigned short [unsigned] [addressable] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:184:13:    got restricted __le16 [usertype] <noident>

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl819x_BAProc.c

index 32fbbc9d0d92cf40534ee3d1464119b17d80e602..adc6cc7ca3d6f2070dae8448a3d3b9f61c2a2d20 100644 (file)
@@ -115,14 +115,14 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,
 
        if (ACT_ADDBARSP == type) {
                RT_TRACE(COMP_DBG, "====>to send ADDBARSP\n");
-               tmp = cpu_to_le16(StatusCode);
+               tmp = StatusCode;
                memcpy(tag, (u8 *)&tmp, 2);
                tag += 2;
        }
-       tmp = cpu_to_le16(pBA->BaParamSet.shortData);
+       tmp = pBA->BaParamSet.shortData;
        memcpy(tag, (u8 *)&tmp, 2);
        tag += 2;
-       tmp = cpu_to_le16(pBA->BaTimeoutValue);
+       tmp = pBA->BaTimeoutValue;
        memcpy(tag, (u8 *)&tmp, 2);
        tag += 2;
 
@@ -178,10 +178,10 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device *ieee, u8 *dst,
        *tag ++= ACT_CAT_BA;
        *tag ++= ACT_DELBA;
 
-       tmp = cpu_to_le16(DelbaParamSet.shortData);
+       tmp = DelbaParamSet.shortData;
        memcpy(tag, (u8 *)&tmp, 2);
        tag += 2;
-       tmp = cpu_to_le16(ReasonCode);
+       tmp = ReasonCode;
        memcpy(tag, (u8 *)&tmp, 2);
        tag += 2;