drm/i915/huc: fix status check
authorDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Tue, 23 Jul 2019 15:37:33 +0000 (08:37 -0700)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 23 Jul 2019 16:20:19 +0000 (17:20 +0100)
Fix botched refactoring of the code that uncorrectly split a check on a
bool, treating it as a u32.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over i915 in GuC/HuC paths")
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20190723153733.19401-1-daniele.ceraolospurio@intel.com
drivers/gpu/drm/i915/gt/uc/intel_huc.c

index bc14439173d76f2a0c0a388cebbab86c67ffef11..ab6c1564b6a7c5a7657f63d941ccc25760872d1c 100644 (file)
@@ -162,7 +162,7 @@ int intel_huc_check_status(struct intel_huc *huc)
 {
        struct intel_gt *gt = huc_to_gt(huc);
        intel_wakeref_t wakeref;
-       bool status = false;
+       u32 status = 0;
 
        if (!intel_uc_is_using_huc(&gt->uc))
                return -ENODEV;