ASoC: soc-pcm: add soc_rtd_prepare()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Wed, 22 Jan 2020 00:44:44 +0000 (09:44 +0900)
committerMark Brown <broonie@kernel.org>
Thu, 23 Jan 2020 12:19:50 +0000 (12:19 +0000)
Add soc_rtd_prepare() to make the code easier to read

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/875zh4mi9v.wl-kuninori.morimoto.gx@renesas.com
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c

index 8095c64c4e3ec470fed01d5c60bda36528aa209d..ccd6c9ca55abf703567d73bc5a7ba884cf861423 100644 (file)
@@ -45,6 +45,15 @@ static void soc_rtd_shutdown(struct snd_soc_pcm_runtime *rtd,
                rtd->dai_link->ops->shutdown(substream);
 }
 
+static int soc_rtd_prepare(struct snd_soc_pcm_runtime *rtd,
+                          struct snd_pcm_substream *substream)
+{
+       if (rtd->dai_link->ops &&
+           rtd->dai_link->ops->prepare)
+               return rtd->dai_link->ops->prepare(substream);
+       return 0;
+}
+
 /**
  * snd_soc_runtime_activate() - Increment active count for PCM runtime components
  * @rtd: ASoC PCM runtime that is activated
@@ -716,13 +725,11 @@ static int soc_pcm_prepare(struct snd_pcm_substream *substream)
 
        mutex_lock_nested(&rtd->card->pcm_mutex, rtd->card->pcm_subclass);
 
-       if (rtd->dai_link->ops->prepare) {
-               ret = rtd->dai_link->ops->prepare(substream);
-               if (ret < 0) {
-                       dev_err(rtd->card->dev, "ASoC: machine prepare error:"
-                               " %d\n", ret);
-                       goto out;
-               }
+       ret = soc_rtd_prepare(rtd, substream);
+       if (ret < 0) {
+               dev_err(rtd->card->dev,
+                       "ASoC: machine prepare error: %d\n", ret);
+               goto out;
        }
 
        for_each_rtd_components(rtd, i, component) {