staging: greybus: loopback: Fix iteration count on async path
authorBryan O'Donoghue <pure.logic@nexus-software.ie>
Mon, 6 Nov 2017 01:32:20 +0000 (01:32 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Nov 2017 15:41:22 +0000 (16:41 +0100)
Commit 12927835d211 ("greybus: loopback: Add asynchronous bi-directional
support") does what it says on the tin - namely, adds support for
asynchronous bi-directional loopback operations.

What it neglects to do though is increment the per-connection
gb->iteration_count on an asynchronous operation error. This patch fixes
that omission.

Fixes: 12927835d211 ("greybus: loopback: Add asynchronous bi-directional support")
Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Reported-by: Mitch Tasman <tasman@leaflabs.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
Cc: Alex Elder <elder@kernel.org>
Cc: Mitch Tasman <tasman@leaflabs.com>
Cc: greybus-dev@lists.linaro.org
Cc: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/loopback.c

index 20d1b4505817c5cb0a5cec62caaecbb764aa8b3c..9c5980cc77917e0cc25cd45f8b538b74b9001997 100644 (file)
@@ -1021,8 +1021,10 @@ static int gb_loopback_fn(void *data)
                        else if (type == GB_LOOPBACK_TYPE_SINK)
                                error = gb_loopback_async_sink(gb, size);
 
-                       if (error)
+                       if (error) {
                                gb->error++;
+                               gb->iteration_count++;
+                       }
                } else {
                        /* We are effectively single threaded here */
                        if (type == GB_LOOPBACK_TYPE_PING)