drm/mst: Don't ignore the MST PBN self-test result
authorImre Deak <imre.deak@intel.com>
Fri, 29 Jan 2016 12:44:28 +0000 (14:44 +0200)
committerDave Airlie <airlied@redhat.com>
Fri, 5 Feb 2016 05:23:48 +0000 (15:23 +1000)
Otherwise this call would have no effect.

Caught by Coverity.

Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: David Weinehall <david.weinehall@intel.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/drm_dp_mst_topology.c

index fe273b681fe50a78292713b3b89e2847e15f57b9..2b7c2f0688340aebf2f827875b87f488b4bf0a2b 100644 (file)
@@ -2855,7 +2855,9 @@ int drm_dp_mst_topology_mgr_init(struct drm_dp_mst_topology_mgr *mgr,
        if (!mgr->proposed_vcpis)
                return -ENOMEM;
        set_bit(0, &mgr->payload_mask);
-       test_calc_pbn_mode();
+       if (test_calc_pbn_mode() < 0)
+               DRM_ERROR("MST PBN self-test failed\n");
+
        return 0;
 }
 EXPORT_SYMBOL(drm_dp_mst_topology_mgr_init);