ALSA: es1688_lib: Deletion of an unnecessary check before the function call "release_...
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 21 Nov 2014 18:05:50 +0000 (19:05 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 21 Nov 2014 19:07:13 +0000 (20:07 +0100)
The release_and_free_resource() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/es1688/es1688_lib.c

index de810e484bdf1beec9e15864b830c207e2989f81..b5450143407b2f43041921c081b16e973899986e 100644 (file)
@@ -614,8 +614,7 @@ static int snd_es1688_free(struct snd_es1688 *chip)
 {
        if (chip->hardware != ES1688_HW_UNDEF)
                snd_es1688_init(chip, 0);
-       if (chip->res_port)
-               release_and_free_resource(chip->res_port);
+       release_and_free_resource(chip->res_port);
        if (chip->irq >= 0)
                free_irq(chip->irq, (void *) chip);
        if (chip->dma8 >= 0) {