marvell: comphy_a3700: fix bitmask
authorAndre Przywara <andre.przywara@arm.com>
Wed, 16 Nov 2016 00:50:10 +0000 (00:50 +0000)
committerTom Rini <trini@konsulko.com>
Sun, 4 Dec 2016 18:55:02 +0000 (13:55 -0500)
Obviously the mask for the rx and tx select field cannot be right,
as it would overlap in one and exceed the 32-bit register in the other
case. From looking at the neighbouring bits it looks like the mask
should be really 4 bits wide instead of 8.

Pointed out by a GCC 6.2 (default) warning.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Stefan Roese <sr@denx.de>
drivers/phy/marvell/comphy_a3700.h

index eb2ed7b317219401c7b6b4acf1f754fa480a273a..dd60b882dddcd712865be0d860c714efc430f9af 100644 (file)
@@ -33,9 +33,9 @@
 #define rb_pin_pu_tx                   BIT(18)
 #define rb_pin_tx_idle                 BIT(19)
 #define rf_gen_rx_sel_shift            22
-#define rf_gen_rx_select               (0xFF << rf_gen_rx_sel_shift)
+#define rf_gen_rx_select               (0x0F << rf_gen_rx_sel_shift)
 #define rf_gen_tx_sel_shift            26
-#define rf_gen_tx_select               (0xFF << rf_gen_tx_sel_shift)
+#define rf_gen_tx_select               (0x0F << rf_gen_tx_sel_shift)
 #define rb_phy_rx_init                 BIT(30)
 
 #define COMPHY_PHY_STAT1_ADDR(lane)    MVEBU_REG(0x018318 + (lane) * 0x28)