ipv6: do not set routes if disable_ipv6 has been enabled
authorLorenzo Bianconi <lorenzo.bianconi@redhat.com>
Thu, 29 Mar 2018 09:02:24 +0000 (11:02 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Mar 2018 16:20:52 +0000 (12:20 -0400)
Do not allow setting ipv6 routes from userspace if disable_ipv6 has been
enabled. The issue can be triggered using the following reproducer:

- sysctl net.ipv6.conf.all.disable_ipv6=1
- ip -6 route add a:b:c:d::/64 dev em1
- ip -6 route show
  a:b:c:d::/64 dev em1 metric 1024 pref medium

Fix it checking disable_ipv6 value in ip6_route_info_create routine

Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/route.c

index ba8d5df50ebea57938683cc75d07ef2bd8a7f691..e461ef1158b6a56a4c0664bf902616863a09e042 100644 (file)
@@ -2917,6 +2917,12 @@ static struct rt6_info *ip6_route_info_create(struct fib6_config *cfg,
        if (!dev)
                goto out;
 
+       if (idev->cnf.disable_ipv6) {
+               NL_SET_ERR_MSG(extack, "IPv6 is disabled on nexthop device");
+               err = -EACCES;
+               goto out;
+       }
+
        if (!(dev->flags & IFF_UP)) {
                NL_SET_ERR_MSG(extack, "Nexthop device is not up");
                err = -ENETDOWN;