zsmalloc: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Jan 2019 15:21:09 +0000 (16:21 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Jun 2019 13:39:39 +0000 (15:39 +0200)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Minchan Kim <minchan@kernel.org>
Cc: Nitin Gupta <ngupta@vflare.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: linux-mm@kvack.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mm/zsmalloc.c

index 0787d33b80d83f1dcfa0fcddb8225f0c859b1402..1347d7922ea2a977b286b044fb58f21983e25e67 100644 (file)
@@ -575,8 +575,6 @@ static void __init zs_stat_init(void)
        }
 
        zs_stat_root = debugfs_create_dir("zsmalloc", NULL);
-       if (!zs_stat_root)
-               pr_warn("debugfs 'zsmalloc' stat dir creation failed\n");
 }
 
 static void __exit zs_stat_exit(void)
@@ -654,22 +652,10 @@ static void zs_pool_stat_create(struct zs_pool *pool, const char *name)
                return;
        }
 
-       entry = debugfs_create_dir(name, zs_stat_root);
-       if (!entry) {
-               pr_warn("debugfs dir <%s> creation failed\n", name);
-               return;
-       }
-       pool->stat_dentry = entry;
-
-       entry = debugfs_create_file("classes", S_IFREG | 0444,
-                                   pool->stat_dentry, pool,
-                                   &zs_stats_size_fops);
-       if (!entry) {
-               pr_warn("%s: debugfs file entry <%s> creation failed\n",
-                               name, "classes");
-               debugfs_remove_recursive(pool->stat_dentry);
-               pool->stat_dentry = NULL;
-       }
+       pool->stat_dentry = debugfs_create_dir(name, zs_stat_root);
+
+       debugfs_create_file("classes", S_IFREG | 0444, pool->stat_dentry, pool,
+                           &zs_stats_size_fops);
 }
 
 static void zs_pool_stat_destroy(struct zs_pool *pool)