Changes for new version of image loading in BL1/BL2
authorYatharth Kochar <yatharth.kochar@arm.com>
Mon, 12 Sep 2016 15:10:33 +0000 (16:10 +0100)
committerYatharth Kochar <yatharth.kochar@arm.com>
Tue, 20 Sep 2016 15:16:42 +0000 (16:16 +0100)
This patch adds changes in BL1 & BL2 to use new version
of image loading to load the BL images.

Following are the changes in BL1:
  -Use new version of load_auth_image() to load BL2
  -Modified `bl1_init_bl2_mem_layout()` to remove using
   `reserve_mem()` and to calculate `bl2_mem_layout`.
   `bl2_mem_layout` calculation now assumes that BL1 RW
   data is at the top of the bl1_mem_layout, which is more
   restrictive than the previous BL1 behaviour.

Following are the changes in BL2:
  -The `bl2_main.c` is refactored and all the functions
   for loading BLxx images are now moved to `bl2_image_load.c`
   `bl2_main.c` now calls a top level `bl2_load_images()` to
   load all the images that are applicable in BL2.
  -Added new file `bl2_image_load_v2.c` that uses new version
   of image loading to load the BL images in BL2.

All the above changes are conditionally compiled using the
`LOAD_IMAGE_V2` flag.

Change-Id: Ic6dcde5a484495bdc05526d9121c59fa50c1bf23

bl1/bl1_main.c
bl2/bl2.mk
bl2/bl2_image_load.c [new file with mode: 0644]
bl2/bl2_image_load_v2.c [new file with mode: 0644]
bl2/bl2_main.c
bl2/bl2_private.h
include/plat/common/common_def.h

index cb1bc1862dd5b91ae1d0269006e6590fdfa23eb1..68a17a3c9d0a2fcd986605a37a827ca5b95838c2 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013-2015, ARM Limited and Contributors. All rights reserved.
+ * Copyright (c) 2013-2016, ARM Limited and Contributors. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
@@ -64,11 +64,19 @@ static void bl1_load_bl2(void);
 void bl1_init_bl2_mem_layout(const meminfo_t *bl1_mem_layout,
                             meminfo_t *bl2_mem_layout)
 {
-       const size_t bl1_size = BL1_RAM_LIMIT - BL1_RAM_BASE;
 
        assert(bl1_mem_layout != NULL);
        assert(bl2_mem_layout != NULL);
 
+#if LOAD_IMAGE_V2
+       /*
+        * Remove BL1 RW data from the scope of memory visible to BL2.
+        * This is assuming BL1 RW data is at the top of bl1_mem_layout.
+        */
+       assert(BL1_RW_BASE > bl1_mem_layout->total_base);
+       bl2_mem_layout->total_base = bl1_mem_layout->total_base;
+       bl2_mem_layout->total_size = BL1_RW_BASE - bl1_mem_layout->total_base;
+#else
        /* Check that BL1's memory is lying outside of the free memory */
        assert((BL1_RAM_LIMIT <= bl1_mem_layout->free_base) ||
               (BL1_RAM_BASE >= bl1_mem_layout->free_base +
@@ -79,7 +87,8 @@ void bl1_init_bl2_mem_layout(const meminfo_t *bl1_mem_layout,
        reserve_mem(&bl2_mem_layout->total_base,
                    &bl2_mem_layout->total_size,
                    BL1_RAM_BASE,
-                   bl1_size);
+                   BL1_RAM_LIMIT - BL1_RAM_BASE);
+#endif /* LOAD_IMAGE_V2 */
 
        flush_dcache_range((unsigned long)bl2_mem_layout, sizeof(meminfo_t));
 }
@@ -182,6 +191,9 @@ void bl1_load_bl2(void)
 
        INFO("BL1: Loading BL2\n");
 
+#if LOAD_IMAGE_V2
+       err = load_auth_image(BL2_IMAGE_ID, image_info);
+#else
        /* Load the BL2 image */
        err = load_auth_image(bl1_tzram_layout,
                         BL2_IMAGE_ID,
@@ -189,6 +201,8 @@ void bl1_load_bl2(void)
                         image_info,
                         ep_info);
 
+#endif /* LOAD_IMAGE_V2 */
+
        if (err) {
                ERROR("Failed to load BL2 firmware.\n");
                plat_error_handler(err);
@@ -201,7 +215,12 @@ void bl1_load_bl2(void)
         * to BL2. BL2 will read the memory layout before using its
         * memory for other purposes.
         */
+#if LOAD_IMAGE_V2
+       bl2_tzram_layout = (meminfo_t *) bl1_tzram_layout->total_base;
+#else
        bl2_tzram_layout = (meminfo_t *) bl1_tzram_layout->free_base;
+#endif /* LOAD_IMAGE_V2 */
+
        bl1_init_bl2_mem_layout(bl1_tzram_layout, bl2_tzram_layout);
 
        ep_info->args.arg1 = (unsigned long)bl2_tzram_layout;
index d7907389002ae5592f9dfcf501b3ceb4a30e515d..6cb478d14f4ae0dea31a7409cc9939f8a8440306 100644 (file)
@@ -34,4 +34,10 @@ BL2_SOURCES          +=      bl2/bl2_main.c                          \
                                common/aarch64/early_exceptions.S       \
                                lib/locks/exclusive/aarch64/spinlock.S
 
+ifeq (${LOAD_IMAGE_V2},1)
+BL2_SOURCES            +=      bl2/bl2_image_load_v2.c
+else
+BL2_SOURCES            +=      bl2/bl2_image_load.c
+endif
+
 BL2_LINKERFILE         :=      bl2/bl2.ld.S
diff --git a/bl2/bl2_image_load.c b/bl2/bl2_image_load.c
new file mode 100644 (file)
index 0000000..ee0eb96
--- /dev/null
@@ -0,0 +1,285 @@
+/*
+ * Copyright (c) 2016, ARM Limited and Contributors. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * Redistributions of source code must retain the above copyright notice, this
+ * list of conditions and the following disclaimer.
+ *
+ * Redistributions in binary form must reproduce the above copyright notice,
+ * this list of conditions and the following disclaimer in the documentation
+ * and/or other materials provided with the distribution.
+ *
+ * Neither the name of ARM nor the names of its contributors may be used
+ * to endorse or promote products derived from this software without specific
+ * prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <arch.h>
+#include <arch_helpers.h>
+#include <assert.h>
+#include <auth_mod.h>
+#include <bl_common.h>
+#include <debug.h>
+#include <errno.h>
+#include <platform.h>
+#include <platform_def.h>
+#include <stdint.h>
+
+/*
+ * Check for platforms that use obsolete image terminology
+ */
+#ifdef BL30_BASE
+# error "BL30_BASE platform define no longer used - please use SCP_BL2_BASE"
+#endif
+
+/*******************************************************************************
+ * Load the SCP_BL2 image if there's one.
+ * If a platform does not want to attempt to load SCP_BL2 image it must leave
+ * SCP_BL2_BASE undefined.
+ * Return 0 on success or if there's no SCP_BL2 image to load, a negative error
+ * code otherwise.
+ ******************************************************************************/
+static int load_scp_bl2(void)
+{
+       int e = 0;
+#ifdef SCP_BL2_BASE
+       meminfo_t scp_bl2_mem_info;
+       image_info_t scp_bl2_image_info;
+
+       /*
+        * It is up to the platform to specify where SCP_BL2 should be loaded if
+        * it exists. It could create space in the secure sram or point to a
+        * completely different memory.
+        *
+        * The entry point information is not relevant in this case as the AP
+        * won't execute the SCP_BL2 image.
+        */
+       INFO("BL2: Loading SCP_BL2\n");
+       bl2_plat_get_scp_bl2_meminfo(&scp_bl2_mem_info);
+       scp_bl2_image_info.h.version = VERSION_1;
+       e = load_auth_image(&scp_bl2_mem_info,
+                           SCP_BL2_IMAGE_ID,
+                           SCP_BL2_BASE,
+                           &scp_bl2_image_info,
+                           NULL);
+
+       if (e == 0) {
+               /* The subsequent handling of SCP_BL2 is platform specific */
+               e = bl2_plat_handle_scp_bl2(&scp_bl2_image_info);
+               if (e) {
+                       ERROR("Failure in platform-specific handling of SCP_BL2 image.\n");
+               }
+       }
+#endif /* SCP_BL2_BASE */
+
+       return e;
+}
+
+#ifndef EL3_PAYLOAD_BASE
+/*******************************************************************************
+ * Load the BL31 image.
+ * The bl2_to_bl31_params and bl31_ep_info params will be updated with the
+ * relevant BL31 information.
+ * Return 0 on success, a negative error code otherwise.
+ ******************************************************************************/
+static int load_bl31(bl31_params_t *bl2_to_bl31_params,
+                    entry_point_info_t *bl31_ep_info)
+{
+       meminfo_t *bl2_tzram_layout;
+       int e;
+
+       INFO("BL2: Loading BL31\n");
+       assert(bl2_to_bl31_params != NULL);
+       assert(bl31_ep_info != NULL);
+
+       /* Find out how much free trusted ram remains after BL2 load */
+       bl2_tzram_layout = bl2_plat_sec_mem_layout();
+
+       /* Set the X0 parameter to BL31 */
+       bl31_ep_info->args.arg0 = (unsigned long)bl2_to_bl31_params;
+
+       /* Load the BL31 image */
+       e = load_auth_image(bl2_tzram_layout,
+                           BL31_IMAGE_ID,
+                           BL31_BASE,
+                           bl2_to_bl31_params->bl31_image_info,
+                           bl31_ep_info);
+
+       if (e == 0) {
+               bl2_plat_set_bl31_ep_info(bl2_to_bl31_params->bl31_image_info,
+                                         bl31_ep_info);
+       }
+
+       return e;
+}
+
+/*******************************************************************************
+ * Load the BL32 image if there's one.
+ * The bl2_to_bl31_params param will be updated with the relevant BL32
+ * information.
+ * If a platform does not want to attempt to load BL32 image it must leave
+ * BL32_BASE undefined.
+ * Return 0 on success or if there's no BL32 image to load, a negative error
+ * code otherwise.
+ ******************************************************************************/
+static int load_bl32(bl31_params_t *bl2_to_bl31_params)
+{
+       int e = 0;
+#ifdef BL32_BASE
+       meminfo_t bl32_mem_info;
+
+       INFO("BL2: Loading BL32\n");
+       assert(bl2_to_bl31_params != NULL);
+
+       /*
+        * It is up to the platform to specify where BL32 should be loaded if
+        * it exists. It could create space in the secure sram or point to a
+        * completely different memory.
+        */
+       bl2_plat_get_bl32_meminfo(&bl32_mem_info);
+       e = load_auth_image(&bl32_mem_info,
+                           BL32_IMAGE_ID,
+                           BL32_BASE,
+                           bl2_to_bl31_params->bl32_image_info,
+                           bl2_to_bl31_params->bl32_ep_info);
+
+       if (e == 0) {
+               bl2_plat_set_bl32_ep_info(
+                       bl2_to_bl31_params->bl32_image_info,
+                       bl2_to_bl31_params->bl32_ep_info);
+       }
+#endif /* BL32_BASE */
+
+       return e;
+}
+
+#ifndef PRELOADED_BL33_BASE
+/*******************************************************************************
+ * Load the BL33 image.
+ * The bl2_to_bl31_params param will be updated with the relevant BL33
+ * information.
+ * Return 0 on success, a negative error code otherwise.
+ ******************************************************************************/
+static int load_bl33(bl31_params_t *bl2_to_bl31_params)
+{
+       meminfo_t bl33_mem_info;
+       int e;
+
+       INFO("BL2: Loading BL33\n");
+       assert(bl2_to_bl31_params != NULL);
+
+       bl2_plat_get_bl33_meminfo(&bl33_mem_info);
+
+       /* Load the BL33 image in non-secure memory provided by the platform */
+       e = load_auth_image(&bl33_mem_info,
+                           BL33_IMAGE_ID,
+                           plat_get_ns_image_entrypoint(),
+                           bl2_to_bl31_params->bl33_image_info,
+                           bl2_to_bl31_params->bl33_ep_info);
+
+       if (e == 0) {
+               bl2_plat_set_bl33_ep_info(bl2_to_bl31_params->bl33_image_info,
+                                         bl2_to_bl31_params->bl33_ep_info);
+       }
+
+       return e;
+}
+#endif /* PRELOADED_BL33_BASE */
+
+#endif /* EL3_PAYLOAD_BASE */
+
+/*******************************************************************************
+ * This function loads SCP_BL2/BL3x images and returns the ep_info for
+ * the next executable image.
+ ******************************************************************************/
+entry_point_info_t *bl2_load_images(void)
+{
+       bl31_params_t *bl2_to_bl31_params;
+       entry_point_info_t *bl31_ep_info;
+       int e;
+
+       e = load_scp_bl2();
+       if (e) {
+               ERROR("Failed to load SCP_BL2 (%i)\n", e);
+               plat_error_handler(e);
+       }
+
+       /* Perform platform setup in BL2 after loading SCP_BL2 */
+       bl2_platform_setup();
+
+       /*
+        * Get a pointer to the memory the platform has set aside to pass
+        * information to BL31.
+        */
+       bl2_to_bl31_params = bl2_plat_get_bl31_params();
+       bl31_ep_info = bl2_plat_get_bl31_ep_info();
+
+#ifdef EL3_PAYLOAD_BASE
+       /*
+        * In the case of an EL3 payload, we don't need to load any further
+        * images. Just update the BL31 entrypoint info structure to make BL1
+        * jump to the EL3 payload.
+        * The pointer to the memory the platform has set aside to pass
+        * information to BL31 in the normal boot flow is reused here, even
+        * though only a fraction of the information contained in the
+        * bl31_params_t structure makes sense in the context of EL3 payloads.
+        * This will be refined in the future.
+        */
+       INFO("BL2: Populating the entrypoint info for the EL3 payload\n");
+       bl31_ep_info->pc = EL3_PAYLOAD_BASE;
+       bl31_ep_info->args.arg0 = (unsigned long) bl2_to_bl31_params;
+       bl2_plat_set_bl31_ep_info(NULL, bl31_ep_info);
+#else
+       e = load_bl31(bl2_to_bl31_params, bl31_ep_info);
+       if (e) {
+               ERROR("Failed to load BL31 (%i)\n", e);
+               plat_error_handler(e);
+       }
+
+       e = load_bl32(bl2_to_bl31_params);
+       if (e) {
+               if (e == -EAUTH) {
+                       ERROR("Failed to authenticate BL32\n");
+                       plat_error_handler(e);
+               } else {
+                       WARN("Failed to load BL32 (%i)\n", e);
+               }
+       }
+
+#ifdef PRELOADED_BL33_BASE
+       /*
+        * In this case, don't load the BL33 image as it's already loaded in
+        * memory. Update BL33 entrypoint information.
+        */
+       INFO("BL2: Populating the entrypoint info for the preloaded BL33\n");
+       bl2_to_bl31_params->bl33_ep_info->pc = PRELOADED_BL33_BASE;
+       bl2_plat_set_bl33_ep_info(NULL, bl2_to_bl31_params->bl33_ep_info);
+#else
+       e = load_bl33(bl2_to_bl31_params);
+       if (e) {
+               ERROR("Failed to load BL33 (%i)\n", e);
+               plat_error_handler(e);
+       }
+#endif /* PRELOADED_BL33_BASE */
+
+#endif /* EL3_PAYLOAD_BASE */
+
+       /* Flush the params to be passed to memory */
+       bl2_plat_flush_bl31_params();
+
+       return bl31_ep_info;
+}
diff --git a/bl2/bl2_image_load_v2.c b/bl2/bl2_image_load_v2.c
new file mode 100644 (file)
index 0000000..4fab655
--- /dev/null
@@ -0,0 +1,117 @@
+/*
+ * Copyright (c) 2016, ARM Limited and Contributors. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * Redistributions of source code must retain the above copyright notice, this
+ * list of conditions and the following disclaimer.
+ *
+ * Redistributions in binary form must reproduce the above copyright notice,
+ * this list of conditions and the following disclaimer in the documentation
+ * and/or other materials provided with the distribution.
+ *
+ * Neither the name of ARM nor the names of its contributors may be used
+ * to endorse or promote products derived from this software without specific
+ * prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <arch.h>
+#include <arch_helpers.h>
+#include <assert.h>
+#include <auth_mod.h>
+#include <bl_common.h>
+#include <debug.h>
+#include <desc_image_load.h>
+#include <platform.h>
+#include <platform_def.h>
+#include <stdint.h>
+
+
+/*******************************************************************************
+ * This function loads SCP_BL2/BL3x images and returns the ep_info for
+ * the next executable image.
+ ******************************************************************************/
+entry_point_info_t *bl2_load_images(void)
+{
+       bl_params_t *bl2_to_next_bl_params;
+       bl_load_info_t *bl2_load_info;
+       const bl_load_info_node_t *bl2_node_info;
+       int plat_setup_done = 0;
+       int err;
+
+       /*
+        * Get information about the images to load.
+        */
+       bl2_load_info = plat_get_bl_image_load_info();
+       assert(bl2_load_info);
+       assert(bl2_load_info->head);
+       assert(bl2_load_info->h.type == PARAM_BL_LOAD_INFO);
+       assert(bl2_load_info->h.version >= VERSION_2);
+       bl2_node_info = bl2_load_info->head;
+
+       while (bl2_node_info) {
+               /*
+                * Perform platform setup before loading the image,
+                * if indicated in the image attributes AND if NOT
+                * already done before.
+                */
+               if (bl2_node_info->image_info->h.attr & IMAGE_ATTRIB_PLAT_SETUP) {
+                       if (plat_setup_done) {
+                               WARN("BL2: Platform setup already done!!\n");
+                       } else {
+                               INFO("BL2: Doing platform setup\n");
+                               bl2_platform_setup();
+                               plat_setup_done = 1;
+                       }
+               }
+
+               if (!(bl2_node_info->image_info->h.attr & IMAGE_ATTRIB_SKIP_LOADING)) {
+                       INFO("BL2: Loading image id %d\n", bl2_node_info->image_id);
+                       err = load_auth_image(bl2_node_info->image_id,
+                               bl2_node_info->image_info);
+                       if (err) {
+                               ERROR("BL2: Failed to load image (%i)\n", err);
+                               plat_error_handler(err);
+                       }
+               } else {
+                       INFO("BL2: Skip loading image id %d\n", bl2_node_info->image_id);
+               }
+
+               /* Allow platform to handle image information. */
+               err = bl2_plat_handle_post_image_load(bl2_node_info->image_id);
+               if (err) {
+                       ERROR("BL2: Failure in post image load handling (%i)\n", err);
+                       plat_error_handler(err);
+               }
+
+               /* Go to next image */
+               bl2_node_info = bl2_node_info->next_load_info;
+       }
+
+       /*
+        * Get information to pass to the next image.
+        */
+       bl2_to_next_bl_params = plat_get_next_bl_params();
+       assert(bl2_to_next_bl_params);
+       assert(bl2_to_next_bl_params->head);
+       assert(bl2_to_next_bl_params->h.type == PARAM_BL_PARAMS);
+       assert(bl2_to_next_bl_params->h.version >= VERSION_2);
+
+       /* Flush the parameters to be passed to next image */
+       plat_flush_next_bl_params();
+
+       return bl2_to_next_bl_params->head->ep_info;
+}
index c8fd683c1a9d89f7d89d1aa0dc7b27b3d55979f6..fc93e1b1109fbe96150a39c47442f6bab5518a4a 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013-2014, ARM Limited and Contributors. All rights reserved.
+ * Copyright (c) 2013-2016, ARM Limited and Contributors. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  * POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include <arch.h>
 #include <arch_helpers.h>
-#include <assert.h>
 #include <auth_mod.h>
 #include <bl1.h>
 #include <bl_common.h>
 #include <debug.h>
-#include <errno.h>
 #include <platform.h>
-#include <platform_def.h>
-#include <stdint.h>
 #include "bl2_private.h"
 
-/*
- * Check for platforms that use obsolete image terminology
- */
-#ifdef BL30_BASE
-# error "BL30_BASE platform define no longer used - please use SCP_BL2_BASE"
-#endif
-
-/*******************************************************************************
- * Load the SCP_BL2 image if there's one.
- * If a platform does not want to attempt to load SCP_BL2 image it must leave
- * SCP_BL2_BASE undefined.
- * Return 0 on success or if there's no SCP_BL2 image to load, a negative error
- * code otherwise.
- ******************************************************************************/
-static int load_scp_bl2(void)
-{
-       int e = 0;
-#ifdef SCP_BL2_BASE
-       meminfo_t scp_bl2_mem_info;
-       image_info_t scp_bl2_image_info;
-
-       /*
-        * It is up to the platform to specify where SCP_BL2 should be loaded if
-        * it exists. It could create space in the secure sram or point to a
-        * completely different memory.
-        *
-        * The entry point information is not relevant in this case as the AP
-        * won't execute the SCP_BL2 image.
-        */
-       INFO("BL2: Loading SCP_BL2\n");
-       bl2_plat_get_scp_bl2_meminfo(&scp_bl2_mem_info);
-       scp_bl2_image_info.h.version = VERSION_1;
-       e = load_auth_image(&scp_bl2_mem_info,
-                           SCP_BL2_IMAGE_ID,
-                           SCP_BL2_BASE,
-                           &scp_bl2_image_info,
-                           NULL);
-
-       if (e == 0) {
-               /* The subsequent handling of SCP_BL2 is platform specific */
-               e = bl2_plat_handle_scp_bl2(&scp_bl2_image_info);
-               if (e) {
-                       ERROR("Failure in platform-specific handling of SCP_BL2 image.\n");
-               }
-       }
-#endif /* SCP_BL2_BASE */
-
-       return e;
-}
-
-#ifndef EL3_PAYLOAD_BASE
-/*******************************************************************************
- * Load the BL31 image.
- * The bl2_to_bl31_params and bl31_ep_info params will be updated with the
- * relevant BL31 information.
- * Return 0 on success, a negative error code otherwise.
- ******************************************************************************/
-static int load_bl31(bl31_params_t *bl2_to_bl31_params,
-                    entry_point_info_t *bl31_ep_info)
-{
-       meminfo_t *bl2_tzram_layout;
-       int e;
-
-       INFO("BL2: Loading BL31\n");
-       assert(bl2_to_bl31_params != NULL);
-       assert(bl31_ep_info != NULL);
-
-       /* Find out how much free trusted ram remains after BL2 load */
-       bl2_tzram_layout = bl2_plat_sec_mem_layout();
-
-       /* Set the X0 parameter to BL31 */
-       bl31_ep_info->args.arg0 = (unsigned long)bl2_to_bl31_params;
-
-       /* Load the BL31 image */
-       e = load_auth_image(bl2_tzram_layout,
-                           BL31_IMAGE_ID,
-                           BL31_BASE,
-                           bl2_to_bl31_params->bl31_image_info,
-                           bl31_ep_info);
-
-       if (e == 0) {
-               bl2_plat_set_bl31_ep_info(bl2_to_bl31_params->bl31_image_info,
-                                         bl31_ep_info);
-       }
-
-       return e;
-}
-
-/*******************************************************************************
- * Load the BL32 image if there's one.
- * The bl2_to_bl31_params param will be updated with the relevant BL32
- * information.
- * If a platform does not want to attempt to load BL32 image it must leave
- * BL32_BASE undefined.
- * Return 0 on success or if there's no BL32 image to load, a negative error
- * code otherwise.
- ******************************************************************************/
-static int load_bl32(bl31_params_t *bl2_to_bl31_params)
-{
-       int e = 0;
-#ifdef BL32_BASE
-       meminfo_t bl32_mem_info;
-
-       INFO("BL2: Loading BL32\n");
-       assert(bl2_to_bl31_params != NULL);
-
-       /*
-        * It is up to the platform to specify where BL32 should be loaded if
-        * it exists. It could create space in the secure sram or point to a
-        * completely different memory.
-        */
-       bl2_plat_get_bl32_meminfo(&bl32_mem_info);
-       e = load_auth_image(&bl32_mem_info,
-                           BL32_IMAGE_ID,
-                           BL32_BASE,
-                           bl2_to_bl31_params->bl32_image_info,
-                           bl2_to_bl31_params->bl32_ep_info);
-
-       if (e == 0) {
-               bl2_plat_set_bl32_ep_info(
-                       bl2_to_bl31_params->bl32_image_info,
-                       bl2_to_bl31_params->bl32_ep_info);
-       }
-#endif /* BL32_BASE */
-
-       return e;
-}
-
-#ifndef PRELOADED_BL33_BASE
-/*******************************************************************************
- * Load the BL33 image.
- * The bl2_to_bl31_params param will be updated with the relevant BL33
- * information.
- * Return 0 on success, a negative error code otherwise.
- ******************************************************************************/
-static int load_bl33(bl31_params_t *bl2_to_bl31_params)
-{
-       meminfo_t bl33_mem_info;
-       int e;
-
-       INFO("BL2: Loading BL33\n");
-       assert(bl2_to_bl31_params != NULL);
-
-       bl2_plat_get_bl33_meminfo(&bl33_mem_info);
-
-       /* Load the BL33 image in non-secure memory provided by the platform */
-       e = load_auth_image(&bl33_mem_info,
-                           BL33_IMAGE_ID,
-                           plat_get_ns_image_entrypoint(),
-                           bl2_to_bl31_params->bl33_image_info,
-                           bl2_to_bl31_params->bl33_ep_info);
-
-       if (e == 0) {
-               bl2_plat_set_bl33_ep_info(bl2_to_bl31_params->bl33_image_info,
-                                         bl2_to_bl31_params->bl33_ep_info);
-       }
-
-       return e;
-}
-#endif /* PRELOADED_BL33_BASE */
-
-#endif /* EL3_PAYLOAD_BASE */
 
 /*******************************************************************************
  * The only thing to do in BL2 is to load further images and pass control to
- * BL31. The memory occupied by BL2 will be reclaimed by BL3x stages. BL2 runs
- * entirely in S-EL1.
+ * next BL. The memory occupied by BL2 will be reclaimed by BL3x stages. BL2
+ * runs entirely in S-EL1.
  ******************************************************************************/
 void bl2_main(void)
 {
-       bl31_params_t *bl2_to_bl31_params;
-       entry_point_info_t *bl31_ep_info;
-       int e;
+       entry_point_info_t *next_bl_ep_info;
 
        NOTICE("BL2: %s\n", version_string);
        NOTICE("BL2: %s\n", build_message);
@@ -226,82 +57,13 @@ void bl2_main(void)
        auth_mod_init();
 #endif /* TRUSTED_BOARD_BOOT */
 
-       /*
-        * Load the subsequent bootloader images
-        */
-       e = load_scp_bl2();
-       if (e) {
-               ERROR("Failed to load SCP_BL2 (%i)\n", e);
-               plat_error_handler(e);
-       }
-
-       /* Perform platform setup in BL2 after loading SCP_BL2 */
-       bl2_platform_setup();
-
-       /*
-        * Get a pointer to the memory the platform has set aside to pass
-        * information to BL31.
-        */
-       bl2_to_bl31_params = bl2_plat_get_bl31_params();
-       bl31_ep_info = bl2_plat_get_bl31_ep_info();
-
-#ifdef EL3_PAYLOAD_BASE
-       /*
-        * In the case of an EL3 payload, we don't need to load any further
-        * images. Just update the BL31 entrypoint info structure to make BL1
-        * jump to the EL3 payload.
-        * The pointer to the memory the platform has set aside to pass
-        * information to BL31 in the normal boot flow is reused here, even
-        * though only a fraction of the information contained in the
-        * bl31_params_t structure makes sense in the context of EL3 payloads.
-        * This will be refined in the future.
-        */
-       INFO("BL2: Populating the entrypoint info for the EL3 payload\n");
-       bl31_ep_info->pc = EL3_PAYLOAD_BASE;
-       bl31_ep_info->args.arg0 = (unsigned long) bl2_to_bl31_params;
-       bl2_plat_set_bl31_ep_info(NULL, bl31_ep_info);
-#else
-       e = load_bl31(bl2_to_bl31_params, bl31_ep_info);
-       if (e) {
-               ERROR("Failed to load BL31 (%i)\n", e);
-               plat_error_handler(e);
-       }
-
-       e = load_bl32(bl2_to_bl31_params);
-       if (e) {
-               if (e == -EAUTH) {
-                       ERROR("Failed to authenticate BL32\n");
-                       plat_error_handler(e);
-               } else {
-                       WARN("Failed to load BL32 (%i)\n", e);
-               }
-       }
-
-#ifdef PRELOADED_BL33_BASE
-       /*
-        * In this case, don't load the BL33 image as it's already loaded in
-        * memory. Update BL33 entrypoint information.
-        */
-       INFO("BL2: Populating the entrypoint info for the preloaded BL33\n");
-       bl2_to_bl31_params->bl33_ep_info->pc = PRELOADED_BL33_BASE;
-       bl2_plat_set_bl33_ep_info(NULL, bl2_to_bl31_params->bl33_ep_info);
-#else
-       e = load_bl33(bl2_to_bl31_params);
-       if (e) {
-               ERROR("Failed to load BL33 (%i)\n", e);
-               plat_error_handler(e);
-       }
-#endif /* PRELOADED_BL33_BASE */
-
-#endif /* EL3_PAYLOAD_BASE */
-
-       /* Flush the params to be passed to memory */
-       bl2_plat_flush_bl31_params();
+       /* Load the subsequent bootloader images. */
+       next_bl_ep_info = bl2_load_images();
 
        /*
-        * Run BL31 via an SMC to BL1. Information on how to pass control to
-        * the BL32 (if present) and BL33 software images will be passed to
-        * BL31 as an argument.
+        * Run next BL image via an SMC to BL1. Information on how to pass
+        * control to the BL32 (if present) and BL33 software images will
+        * be passed to next BL image as an argument.
         */
-       smc(BL1_SMC_RUN_IMAGE, (unsigned long)bl31_ep_info, 0, 0, 0, 0, 0, 0);
+       smc(BL1_SMC_RUN_IMAGE, (unsigned long)next_bl_ep_info, 0, 0, 0, 0, 0, 0);
 }
index 022d1e93b189735e9f53347075cb2699bcc859e8..b33977786e19542f241295ede8093e71a52a9220 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013-2014, ARM Limited and Contributors. All rights reserved.
+ * Copyright (c) 2013-2016, ARM Limited and Contributors. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
 #ifndef __BL2_PRIVATE_H__
 #define __BL2_PRIVATE_H__
 
+/******************************************
+ * Forward declarations
+ *****************************************/
+struct entry_point_info;
+
 /******************************************
  * Function prototypes
  *****************************************/
 void bl2_arch_setup(void);
+struct entry_point_info *bl2_load_images(void);
 
 #endif /* __BL2_PRIVATE_H__ */
index d6b777278f11342ee2769db407959dd668337c8f..7fef3392bd32d534268567225a857559efba1205 100644 (file)
   #define MAKE_ULL(x)                  x
 #endif
 
+#if LOAD_IMAGE_V2
+#define BL2_IMAGE_DESC {                               \
+       .image_id = BL2_IMAGE_ID,                       \
+       SET_STATIC_PARAM_HEAD(image_info, PARAM_EP,     \
+               VERSION_2, image_info_t, 0),            \
+       .image_info.image_base = BL2_BASE,              \
+       .image_info.image_max_size = BL2_LIMIT - BL2_BASE,\
+       SET_STATIC_PARAM_HEAD(ep_info, PARAM_EP,        \
+               VERSION_2, entry_point_info_t, SECURE | EXECUTABLE),\
+       .ep_info.pc = BL2_BASE,                         \
+}
+#else /* LOAD_IMAGE_V2 */
 #define BL2_IMAGE_DESC {                               \
        .image_id = BL2_IMAGE_ID,                       \
        SET_STATIC_PARAM_HEAD(image_info, PARAM_EP,     \
@@ -79,6 +91,7 @@
                VERSION_1, entry_point_info_t, SECURE | EXECUTABLE),\
        .ep_info.pc = BL2_BASE,                         \
 }
+#endif /* LOAD_IMAGE_V2 */
 
 /*
  * The following constants identify the extents of the code & read-only data