MIPS: using strlcpy() instead of strncpy()
authorChen Gang <gang.chen@asianux.com>
Sun, 26 May 2013 07:06:06 +0000 (07:06 +0000)
committerRalf Baechle <ralf@linux-mips.org>
Mon, 10 Jun 2013 16:01:26 +0000 (18:01 +0200)
Ensure strings are always '\0' terminated.  Or in the next pr_info() shit
may hit the fan.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Acked-by: John Crispin <blogic@openwrt.org>
Cc: david.daney@cavium.com
Cc: linux-mips@linux-mips.org
Cc: Linux-Arch <linux-arch@vger.kernel.org>
Cc: linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
Patchwork: https://patchwork.linux-mips.org/patch/5331/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/kernel/prom.c

index 5712bb5322454f1a98d169e58490e77b62e149be..7e954042f2526e66f21579f73d609452a5b1d726 100644 (file)
@@ -30,7 +30,7 @@ __init void mips_set_machine_name(const char *name)
        if (name == NULL)
                return;
 
-       strncpy(mips_machine_name, name, sizeof(mips_machine_name));
+       strlcpy(mips_machine_name, name, sizeof(mips_machine_name));
        pr_info("MIPS: machine is %s\n", mips_get_machine_name());
 }