btrfs: dev-replace: Remove impossible WARN_ON
authorNikolay Borisov <nborisov@suse.com>
Tue, 14 May 2019 10:54:40 +0000 (13:54 +0300)
committerDavid Sterba <dsterba@suse.com>
Mon, 1 Jul 2019 11:34:54 +0000 (13:34 +0200)
This WARN_ON can never trigger because src_device cannot be null.
btrfs_find_device_by_devspec always returns either an error or a valid
pointer to the device. Just remove it.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/dev-replace.c

index 2fa826b12d40eb423d121a4f6de4e1c9c88d45b3..eb8b5cb2c40d5bc8bb97f382d75359fadf083c23 100644 (file)
@@ -447,7 +447,6 @@ static int btrfs_dev_replace_start(struct btrfs_fs_info *fs_info,
        }
 
        dev_replace->cont_reading_from_srcdev_mode = read_src;
-       WARN_ON(!src_device);
        dev_replace->srcdev = src_device;
        dev_replace->tgtdev = tgt_device;