regulator: lp872x: Don't set constraints within the regulator driver
authorMark Brown <broonie@linaro.org>
Mon, 28 Jul 2014 11:32:04 +0000 (12:32 +0100)
committerMark Brown <broonie@linaro.org>
Mon, 28 Jul 2014 12:19:23 +0000 (13:19 +0100)
Regulator drivers should not be specifying constraints since the valid
configurations depend on how the device is used in a given system, there
is no way to know if a configuration is safe for a given board.

Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/regulator/lp872x.c

index 2e022aabd951264bdc575d6b32fbdaa148d77298..021d64d856bb68d72745e83a8258d3c228412943 100644 (file)
@@ -845,7 +845,6 @@ static struct lp872x_platform_data
        struct device_node *np = dev->of_node;
        struct lp872x_platform_data *pdata;
        struct of_regulator_match *match;
-       struct regulator_init_data *d;
        int num_matches;
        int count;
        int i;
@@ -892,14 +891,6 @@ static struct lp872x_platform_data
                pdata->regulator_data[i].id =
                                (enum lp872x_regulator_id)match[i].driver_data;
                pdata->regulator_data[i].init_data = match[i].init_data;
-
-               /* Operation mode configuration for buck/buck1/buck2 */
-               if (strncmp(match[i].name, "buck", 4))
-                       continue;
-
-               d = pdata->regulator_data[i].init_data;
-               d->constraints.valid_modes_mask |= LP872X_VALID_OPMODE;
-               d->constraints.valid_ops_mask |= REGULATOR_CHANGE_MODE;
        }
 out:
        return pdata;