net: ethernet: ti: cpsw: add support for port interface mode selection phy
authorGrygorii Strashko <grygorii.strashko@ti.com>
Mon, 26 Nov 2018 00:15:25 +0000 (18:15 -0600)
committerKishon Vijay Abraham I <kishon@ti.com>
Wed, 12 Dec 2018 04:31:42 +0000 (10:01 +0530)
Add support for port interface mode selection phy (phy-gmii-sel):
- try to request interface mode selection phy from Port DT node and fail
silently if not defined and old CONFIG_TI_CPSW_PHY_SEL driver enabled.
- use new phy if requested successfully.

Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/net/ethernet/ti/cpsw.c

index 500f7ed8c58c3b36480c3b08ea37c79f220024e0..94e5e5b791ecbdfc69b7d381160f29128f0ac6e2 100644 (file)
@@ -26,6 +26,7 @@
 #include <linux/netdevice.h>
 #include <linux/net_tstamp.h>
 #include <linux/phy.h>
+#include <linux/phy/phy.h>
 #include <linux/workqueue.h>
 #include <linux/delay.h>
 #include <linux/pm_runtime.h>
@@ -387,6 +388,7 @@ struct cpsw_slave_data {
        int             phy_if;
        u8              mac_addr[ETH_ALEN];
        u16             dual_emac_res_vlan;     /* Reserved VLAN for DualEMAC */
+       struct phy      *ifphy;
 };
 
 struct cpsw_platform_data {
@@ -1510,7 +1512,12 @@ static void cpsw_slave_open(struct cpsw_slave *slave, struct cpsw_priv *priv)
        phy_start(slave->phy);
 
        /* Configure GMII_SEL register */
-       cpsw_phy_sel(cpsw->dev, slave->phy->interface, slave->slave_num);
+       if (!IS_ERR(slave->data->ifphy))
+               phy_set_mode_ext(slave->data->ifphy, PHY_MODE_ETHERNET,
+                                slave->data->phy_if);
+       else
+               cpsw_phy_sel(cpsw->dev, slave->phy->interface,
+                            slave->slave_num);
 }
 
 static inline void cpsw_add_default_vlan(struct cpsw_priv *priv)
@@ -3147,6 +3154,16 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data,
                if (strcmp(slave_node->name, "slave"))
                        continue;
 
+               slave_data->ifphy = devm_of_phy_get(&pdev->dev, slave_node,
+                                                   NULL);
+               if (!IS_ENABLED(CONFIG_TI_CPSW_PHY_SEL) &&
+                   IS_ERR(slave_data->ifphy)) {
+                       ret = PTR_ERR(slave_data->ifphy);
+                       dev_err(&pdev->dev,
+                               "%d: Error retrieving port phy: %d\n", i, ret);
+                       return ret;
+               }
+
                slave_data->phy_node = of_parse_phandle(slave_node,
                                                        "phy-handle", 0);
                parp = of_get_property(slave_node, "phy_id", &lenp);