wcn36xx: Use kmemdup instead of duplicating it in wcn36xx_smd_process_ptt_msg_rsp
authorYueHaibing <yuehaibing@huawei.com>
Mon, 6 Aug 2018 09:39:07 +0000 (12:39 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 24 Aug 2018 11:48:27 +0000 (14:48 +0300)
Replace calls to kmalloc followed by a memcpy with a direct call to
kmemdup.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/wcn36xx/smd.c

index 00098f24116dea042ad5e57526e4a4cf6b64183d..1d2d698fb77933a8eab236b1b31dc6db240bd484 100644 (file)
@@ -792,10 +792,10 @@ static int wcn36xx_smd_process_ptt_msg_rsp(void *buf, size_t len,
                         rsp->header.len - sizeof(rsp->ptt_msg_resp_status));
 
        if (rsp->header.len > 0) {
-               *p_ptt_rsp_msg = kmalloc(rsp->header.len, GFP_ATOMIC);
+               *p_ptt_rsp_msg = kmemdup(rsp->ptt_msg, rsp->header.len,
+                                        GFP_ATOMIC);
                if (!*p_ptt_rsp_msg)
                        return -ENOMEM;
-               memcpy(*p_ptt_rsp_msg, rsp->ptt_msg, rsp->header.len);
        }
        return ret;
 }