net: nlmon: use standard dev_lstats_add() and dev_lstats_read()
authorEric Dumazet <edumazet@google.com>
Fri, 8 Nov 2019 00:27:16 +0000 (16:27 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 Nov 2019 04:03:08 +0000 (20:03 -0800)
No need to hand-code the exact same functions.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/nlmon.c

index 68771b2f351a228860cdfbc7ab3f028665b2590e..afb119f383252cc4c78e5456d12b7066eb26953f 100644 (file)
@@ -9,13 +9,7 @@
 
 static netdev_tx_t nlmon_xmit(struct sk_buff *skb, struct net_device *dev)
 {
-       int len = skb->len;
-       struct pcpu_lstats *stats = this_cpu_ptr(dev->lstats);
-
-       u64_stats_update_begin(&stats->syncp);
-       stats->bytes += len;
-       stats->packets++;
-       u64_stats_update_end(&stats->syncp);
+       dev_lstats_add(dev, skb->len);
 
        dev_kfree_skb(skb);
 
@@ -56,25 +50,9 @@ static int nlmon_close(struct net_device *dev)
 static void
 nlmon_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats)
 {
-       int i;
-       u64 bytes = 0, packets = 0;
-
-       for_each_possible_cpu(i) {
-               const struct pcpu_lstats *nl_stats;
-               u64 tbytes, tpackets;
-               unsigned int start;
-
-               nl_stats = per_cpu_ptr(dev->lstats, i);
-
-               do {
-                       start = u64_stats_fetch_begin_irq(&nl_stats->syncp);
-                       tbytes = nl_stats->bytes;
-                       tpackets = nl_stats->packets;
-               } while (u64_stats_fetch_retry_irq(&nl_stats->syncp, start));
+       u64 packets, bytes;
 
-               packets += tpackets;
-               bytes += tbytes;
-       }
+       dev_lstats_read(dev, &packets, &bytes);
 
        stats->rx_packets = packets;
        stats->tx_packets = 0;