drm/i915: Drop fb reference on load_detect_pipe failure path
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 7 Dec 2017 22:00:25 +0000 (22:00 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 8 Dec 2017 11:36:48 +0000 (11:36 +0000)
When intel_modeset_setup_plane_state() fails drop the local framebuffer
reference before jumping to the error, otherwise we leak the framebuffer.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Fixes: edde361711ef ("drm/i915: Use atomic state to obtain load detection crtc, v3.")
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171207220025.22698-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_display.c

index e355d780a4cda501752fe84638f2ceeb004e534b..be56f0150cd9a2b91603182dff2e24bb8389c465 100644 (file)
@@ -9939,11 +9939,10 @@ found:
        }
 
        ret = intel_modeset_setup_plane_state(state, crtc, mode, fb, 0, 0);
+       drm_framebuffer_put(fb);
        if (ret)
                goto fail;
 
-       drm_framebuffer_put(fb);
-
        ret = drm_atomic_set_mode_for_crtc(&crtc_state->base, mode);
        if (ret)
                goto fail;