Staging: rtl8192e: Replace memset with eth_zero_addr
authorVaishali Thakkar <vthakkar1994@gmail.com>
Fri, 26 Jun 2015 04:07:25 +0000 (09:37 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Jul 2015 05:46:20 +0000 (22:46 -0700)
Use eth_zero_addr to assign the zero address to the given address
array instead of memset when second argument is address of zero.
Note that the 6 in the third argument of memset appears to represent
an ethernet address size (ETH_ALEN).

The Coccinelle semantic patch that makes this change is as follows:

// <smpl>
@eth_zero_addr@
expression e;
@@

-memset(e,0x00,6);
+eth_zero_addr(e);
// </smpl>

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl819x_TSProc.c
drivers/staging/rtl8192e/rtllib_softmac.c

index 05aea4321b9def15b83ec322bb861d015e0157ae..7087959443cb40e634519fd12df3e5e991292681 100644 (file)
@@ -113,7 +113,7 @@ static void TsAddBaProcess(unsigned long data)
 
 static void ResetTsCommonInfo(struct ts_common_info *pTsCommonInfo)
 {
-       memset(pTsCommonInfo->Addr, 0, 6);
+       eth_zero_addr(pTsCommonInfo->Addr);
        memset(&pTsCommonInfo->TSpec, 0, sizeof(union tspec_body));
        memset(&pTsCommonInfo->TClass, 0, sizeof(union qos_tclas)*TCLAS_NUM);
        pTsCommonInfo->TClasProc = 0;
index 635a1c40c309e9717aba7f17f065c63a3e20136a..1503cbb3574ef7341594190aeeff7eebbd4231f2 100644 (file)
@@ -3086,7 +3086,7 @@ static int rtllib_wpa_enable(struct rtllib_device *ieee, int value)
         */
        netdev_info(ieee->dev, "%s WPA\n", value ? "enabling" : "disabling");
        ieee->wpa_enabled = value;
-       memset(ieee->ap_mac_addr, 0, 6);
+       eth_zero_addr(ieee->ap_mac_addr);
        return 0;
 }