KVM: Remove stat_set from debugfs
authorRusty Russell <rusty@rustcorp.com.au>
Wed, 1 Aug 2007 00:12:22 +0000 (10:12 +1000)
committerAvi Kivity <avi@qumranet.com>
Sat, 13 Oct 2007 08:18:22 +0000 (10:18 +0200)
We shouldn't define stat_set on the debug attributes, since that will
cause silent failure on writing: without a set argument, userspace
will get -EACCESS.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Avi Kivity <avi@qumranet.com>
drivers/kvm/kvm_main.c

index 55639aceca637ccfc295d37c5e9148c7d32c1d23..25d76a5a9999877527b91ca6ae64e2ba135f7c43 100644 (file)
@@ -3017,11 +3017,7 @@ static u64 stat_get(void *_offset)
        return total;
 }
 
-static void stat_set(void *offset, u64 val)
-{
-}
-
-DEFINE_SIMPLE_ATTRIBUTE(stat_fops, stat_get, stat_set, "%llu\n");
+DEFINE_SIMPLE_ATTRIBUTE(stat_fops, stat_get, NULL, "%llu\n");
 
 static __init void kvm_init_debug(void)
 {