mpt3sas: fix Kconfig dependency problem for mpt2sas back compatibility
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Wed, 2 Dec 2015 21:36:58 +0000 (13:36 -0800)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Thu, 3 Dec 2015 17:31:23 +0000 (09:31 -0800)
The non-PCI builds of the O day test project are failing:

On Thu, 2015-12-03 at 05:02 +0800, kbuild test robot wrote:
> warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct
> dependencies (SCSI_LOWLEVEL && PCI && SCSI)

The problem is that select and depend don't interact because Kconfig doesn't
have a SAT solver, so depend picks up dependencies and select does onward
selects, but select doesn't pick up dependencies.  To fix this, we need to add
the correct dependencies to the MPT2SAS option like this.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: b840c3627b6f4f856b333a14a72f8ed86da2f86c
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/mpt3sas/Kconfig

index 25dc38f25ec678c0a041eec33c5e38cf0bf85429..b736dbc8048530e6c2c8dae2a8f7e1aac896ce10 100644 (file)
@@ -76,6 +76,7 @@ config SCSI_MPT2SAS
        tristate "Legacy MPT2SAS config option"
        default n
        select SCSI_MPT3SAS
+       depends on PCI && SCSI
        ---help---
        Dummy config option for backwards compatiblity: configure the MPT3SAS
        driver instead.