ASoC: rt5651: Only configure LDO voltage once at boot
authorHans de Goede <hdegoede@redhat.com>
Sun, 25 Feb 2018 10:46:53 +0000 (11:46 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 1 Mar 2018 19:13:05 +0000 (19:13 +0000)
Now that rt5651_set_bias_level(BIAS_OFF) no longer modifies the LDO
voltage selection bits, there is no need to set them each time we move
to standby. Instead configure them once at component-probe() time.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5651.c

index 74f83af3b6bedbb48f4102d83d2fadc5d9dadc45..9460bdcad3492c9695245428ba33707110b1e43c 100644 (file)
@@ -1540,9 +1540,6 @@ static int rt5651_set_bias_level(struct snd_soc_component *component,
                        snd_soc_component_update_bits(component, RT5651_PWR_ANLG1,
                                RT5651_PWR_FV1 | RT5651_PWR_FV2,
                                RT5651_PWR_FV1 | RT5651_PWR_FV2);
-                       snd_soc_component_update_bits(component, RT5651_PWR_ANLG1,
-                               RT5651_PWR_LDO_DVO_MASK,
-                               RT5651_PWR_LDO_DVO_1_2V);
                        snd_soc_component_update_bits(component, RT5651_D_MISC, 0x1, 0x1);
                }
                break;
@@ -1662,6 +1659,9 @@ static int rt5651_probe(struct snd_soc_component *component)
 
        rt5651->component = component;
 
+       snd_soc_component_update_bits(component, RT5651_PWR_ANLG1,
+               RT5651_PWR_LDO_DVO_MASK, RT5651_PWR_LDO_DVO_1_2V);
+
        snd_soc_component_force_bias_level(component, SND_SOC_BIAS_OFF);
 
        rt5651_apply_properties(component);