mlxsw: core: Remove deprecated create_workqueue
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Tue, 7 Jun 2016 19:59:46 +0000 (01:29 +0530)
committerDavid S. Miller <davem@davemloft.net>
Fri, 10 Jun 2016 06:49:43 +0000 (23:49 -0700)
alloc_workqueue replaces deprecated create_workqueue().

A dedicated workqueue has been used since the workqueue
mlxsw_wq is used for FDB notif. processing with workitems that are
involved in normal device operation && because it's a network device
which can be depended upon during memory reclaim.

Workitems &trans->timeout_dw and &mlxsw_sp->fdb_notify.dw,
map to mlxsw_sp_fdb_notify_work (processes FDB notifications from the
underlying device and resolves the netdev to which the entry points to
and notifies the bridge using the switchdev notifier) and
mlxsw_emad_trans_timeout_work (provides async EMAD register access)
respectively. They require forward progress under memory pressure and
hence, WQ_MEM_RECLAIM has been set.

Since there are only a fixed number of work items, explicit concurrency
limit is unnecessary here.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Tested-by: Ido Schimmel <idosch@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/core.c

index b0a0b01bb4ef76896cf632b06a0b6db4b5c9c08d..01ae54826d5cda607e772004fb67e6937f32ba6c 100644 (file)
@@ -1736,7 +1736,7 @@ static int __init mlxsw_core_module_init(void)
 {
        int err;
 
-       mlxsw_wq = create_workqueue(mlxsw_core_driver_name);
+       mlxsw_wq = alloc_workqueue(mlxsw_core_driver_name, WQ_MEM_RECLAIM, 0);
        if (!mlxsw_wq)
                return -ENOMEM;
        mlxsw_core_dbg_root = debugfs_create_dir(mlxsw_core_driver_name, NULL);