iwlwifi: mvm: fix quota update avoidance

When not updating the quota, the new command shouldn't be stored
as otherwise slowly drifting quota would never update the firmware.
Fix this by storing the command only when it was also sent.

Since the error message also only makes sense when attempting to
send the command, just short-circuit the function when there's no
need to send the command.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

diff --git a/drivers/net/wireless/iwlwifi/mvm/quota.c b/drivers/net/wireless/iwlwifi/mvm/quota.c
index 1eab2f2fee5d994b1c45eaa5d62fb1cebe1ba4ff..dbb2594390e96195c194f9c9ebe8d0967b3924b7 100644 (file)
--- a/drivers/net/wireless/iwlwifi/mvm/quota.c
+++ b/drivers/net/wireless/iwlwifi/mvm/quota.c
@@ -309,17 +309,16 @@ int iwl_mvm_update_quotas(struct iwl_mvm *mvm,
                          "zero quota on binding %d\n", i);
        }
 
-       if (send) {
-               err = iwl_mvm_send_cmd_pdu(mvm, TIME_QUOTA_CMD, 0,
-                                          sizeof(cmd), &cmd);
-       } else {
+       if (!send) {
                /* don't send a practically unchanged command, the firmware has
                 * to re-initialize a lot of state and that can have an adverse
                 * impact on it
                 */
-               err = 0;
+               return 0;
        }
 
+       err = iwl_mvm_send_cmd_pdu(mvm, TIME_QUOTA_CMD, 0, sizeof(cmd), &cmd);
+
        if (err)
                IWL_ERR(mvm, "Failed to send quota: %d\n", err);
        else