Bluetooth: Remove pointless check of hci_send_frame parameter
authorMarcel Holtmann <marcel@holtmann.org>
Thu, 10 Oct 2013 21:54:18 +0000 (14:54 -0700)
committerJohan Hedberg <johan.hedberg@intel.com>
Thu, 10 Oct 2013 22:10:11 +0000 (00:10 +0200)
The hdev parameter of hci_send_frame must be always valid. If the hdev
is not valid, it would not even make it to this stage. The callers
will have already accessed hdev at that point many times.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
net/bluetooth/hci_core.c

index 925bd47c4a3cff9c197eda70fa2c90b1a76b7c75..47cf3a95dac05a2adc1204823cd6bb21ebef40b7 100644 (file)
@@ -2699,11 +2699,6 @@ EXPORT_SYMBOL(hci_unregister_cb);
 
 static int hci_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
 {
-       if (!hdev) {
-               kfree_skb(skb);
-               return -ENODEV;
-       }
-
        BT_DBG("%s type %d len %d", hdev->name, bt_cb(skb)->pkt_type, skb->len);
 
        /* Time stamp */