e1000: error out if we cannot enable PCI device on resume
authorAuke Kok <auke\-jan.h.kok@intel.com>
Mon, 28 Aug 2006 21:56:27 +0000 (14:56 -0700)
committerAuke Kok <juke-jan.h.kok@intel.com>
Mon, 28 Aug 2006 21:56:27 +0000 (14:56 -0700)
Do not ignore errors returned by pci_enable_device, instead error out.

Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
drivers/net/e1000/e1000_main.c

index 426811ad3e9b9235d17101feedbbda1dae848aa3..630fe605e5c4b5e5906898ebc438cecf9aa7cf5d 100644 (file)
@@ -4709,11 +4709,14 @@ e1000_resume(struct pci_dev *pdev)
 {
        struct net_device *netdev = pci_get_drvdata(pdev);
        struct e1000_adapter *adapter = netdev_priv(netdev);
-       uint32_t manc, ret_val;
+       uint32_t manc, err;
 
        pci_set_power_state(pdev, PCI_D0);
        e1000_pci_restore_state(adapter);
-       ret_val = pci_enable_device(pdev);
+       if ((err = pci_enable_device(pdev))) {
+               printk(KERN_ERR "e1000: Cannot enable PCI device from suspend\n");
+               return err;
+       }
        pci_set_master(pdev);
 
        pci_enable_wake(pdev, PCI_D3hot, 0);