ASoC: s6000: Don't set unused struct snd_pcm_hardware fields
authorLars-Peter Clausen <lars@metafoo.de>
Fri, 20 Dec 2013 13:20:19 +0000 (14:20 +0100)
committerMark Brown <broonie@linaro.org>
Tue, 24 Dec 2013 12:02:21 +0000 (12:02 +0000)
The ASoC core assumes that the PCM component of the ASoC card transparently
moves data around and does not impose any restrictions on the memory layout or
the transfer speed. It ignores all fields from the snd_pcm_hardware struct for
the PCM driver that are related to this. Setting these fields in the PCM driver
might suggest otherwise though, so rather not set them.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Daniel Glöckner <daniel-gl@gmx.net>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/s6000/s6000-pcm.c

index d219880815c0142dad341502405a9887977c159d..fb8461e1b1f6664c2aa151b96661c4103fbd61bd 100644 (file)
@@ -33,13 +33,6 @@ static struct snd_pcm_hardware s6000_pcm_hardware = {
        .info = (SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER |
                 SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID |
                 SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_JOINT_DUPLEX),
-       .formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S32_LE),
-       .rates = (SNDRV_PCM_RATE_CONTINUOUS | SNDRV_PCM_RATE_5512 | \
-                 SNDRV_PCM_RATE_8000_192000),
-       .rate_min = 0,
-       .rate_max = 1562500,
-       .channels_min = 2,
-       .channels_max = 8,
        .buffer_bytes_max = 0x7ffffff0,
        .period_bytes_min = 16,
        .period_bytes_max = 0xfffff0,