KVM: apic: short-circuit kvm_apic_accept_pic_intr() when pic intr is accepted
authorMiaohe Lin <linmiaohe@huawei.com>
Sat, 18 Jan 2020 02:50:37 +0000 (10:50 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 27 Jan 2020 18:59:45 +0000 (19:59 +0100)
Short-circuit kvm_apic_accept_pic_intr() when pic intr is accepted, there
is no need to proceed further. Also remove unnecessary var r.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/lapic.c

index 865edce27a6aa18884cca35778db2b38680f3c94..286396c0aa7d68d46e59f665307e48348c53e2d3 100644 (file)
@@ -2375,14 +2375,13 @@ int kvm_apic_has_interrupt(struct kvm_vcpu *vcpu)
 int kvm_apic_accept_pic_intr(struct kvm_vcpu *vcpu)
 {
        u32 lvt0 = kvm_lapic_get_reg(vcpu->arch.apic, APIC_LVT0);
-       int r = 0;
 
        if (!kvm_apic_hw_enabled(vcpu->arch.apic))
-               r = 1;
+               return 1;
        if ((lvt0 & APIC_LVT_MASKED) == 0 &&
            GET_APIC_DELIVERY_MODE(lvt0) == APIC_MODE_EXTINT)
-               r = 1;
-       return r;
+               return 1;
+       return 0;
 }
 
 void kvm_inject_apic_timer_irqs(struct kvm_vcpu *vcpu)