vfio: powerpc/spapr: Disable DMA mappings on disabled container
authorAlexey Kardashevskiy <aik@ozlabs.ru>
Fri, 5 Jun 2015 06:35:02 +0000 (16:35 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 11 Jun 2015 05:14:56 +0000 (15:14 +1000)
At the moment DMA map/unmap requests are handled irrespective to
the container's state. This allows the user space to pin memory which
it might not be allowed to pin.

This adds checks to MAP/UNMAP that the container is enabled, otherwise
-EPERM is returned.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
[aw: for the vfio related changes]
Acked-by: Alex Williamson <alex.williamson@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
drivers/vfio/vfio_iommu_spapr_tce.c

index 6e2e15fdb0df9a56bbcb9baa56e9ff6360435f20..5bbdf378fd59083304f582b36c86d585bb7edf43 100644 (file)
@@ -318,6 +318,9 @@ static long tce_iommu_ioctl(void *iommu_data,
                struct iommu_table *tbl = container->tbl;
                unsigned long tce;
 
+               if (!container->enabled)
+                       return -EPERM;
+
                if (!tbl)
                        return -ENXIO;
 
@@ -362,6 +365,9 @@ static long tce_iommu_ioctl(void *iommu_data,
                struct vfio_iommu_type1_dma_unmap param;
                struct iommu_table *tbl = container->tbl;
 
+               if (!container->enabled)
+                       return -EPERM;
+
                if (WARN_ON(!tbl))
                        return -ENXIO;