Staging: rtlwifi: Cleanup crc16_ccitt()

crc16_ccitt() function does "BIT(0) << i" instead of "BIT(i)".
Using !! is slightly shorter than "foo ? 1: 0" and remove unnecessary
parentheses to make the code simple.

Issue suggested by Coccinelle.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c
index a9902818ae7ece71316ca61e75ab6a710e7266e0..2cce65368f92f5fd7524f98d1da6ab4e0a94d831 100644 (file)
--- a/drivers/staging/rtlwifi/core.c
+++ b/drivers/staging/rtlwifi/core.c
@@ -341,25 +341,25 @@ static u16 crc16_ccitt(u8 data, u16 crc)
        u16 result;
 
        for (i = 0; i < 8; i++) {
-               crc_bit15 = ((crc & BIT(15)) ? 1 : 0);
-               data_bit  = (data & (BIT(0) << i) ? 1 : 0);
+               crc_bit15 = !!(crc & BIT(15));
+               data_bit  = !!(data & BIT(i));
                shift_in = crc_bit15 ^ data_bit;
 
                result = crc << 1;
                if (shift_in == 0)
-                       result &= (~BIT(0));
+                       result &= ~BIT(0);
                else
                        result |= BIT(0);
 
-               crc_bit11 = ((crc & BIT(11)) ? 1 : 0) ^ shift_in;
+               crc_bit11 = !!(crc & BIT(11)) ^ shift_in;
                if (crc_bit11 == 0)
-                       result &= (~BIT(12));
+                       result &= ~BIT(12);
                else
                        result |= BIT(12);
 
-               crc_bit4 = ((crc & BIT(4)) ? 1 : 0) ^ shift_in;
+               crc_bit4 = !!(crc & BIT(4)) ^ shift_in;
                if (crc_bit4 == 0)
-                       result &= (~BIT(5));
+                       result &= ~BIT(5);
                else
                        result |= BIT(5);