staging: erofs: fix memleak of inode's shared xattr array

If it fails to read a shared xattr page, the inode's shared xattr array
is not freed. The next time the inode's xattr is accessed, the previously
allocated array is leaked.

Signed-off-by: Sheng Yong <shengyong1@huawei.com>
Fixes: b17500a0fdba ("staging: erofs: introduce xattr & acl support")
Cc: <stable@vger.kernel.org> # 4.19+
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
index e748df8d2b4472f3c77752b87bc450a931d0c171..8c48b0ab31fd5b62ce5072d467498fde593c9a44 100644 (file)
--- a/drivers/staging/erofs/xattr.c
+++ b/drivers/staging/erofs/xattr.c
@@ -111,8 +111,11 @@ static int init_inode_xattrs(struct inode *inode)
 
                        it.page = erofs_get_meta_page(sb,
                                ++it.blkaddr, S_ISDIR(inode->i_mode));
-                       if (IS_ERR(it.page))
+                       if (IS_ERR(it.page)) {
+                               kfree(vi->xattr_shared_xattrs);
+                               vi->xattr_shared_xattrs = NULL;
                                return PTR_ERR(it.page);
+                       }
 
                        it.kaddr = kmap_atomic(it.page);
                        atomic_map = true;