perf trace beauty fcntl: Do not suppress 'cmd' when zero, should be DUPFD
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 17 Jul 2017 19:02:52 +0000 (16:02 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 19 Jul 2017 02:14:25 +0000 (23:14 -0300)
Before:

 77059.513 ( 0.005 ms): bash/6649 fcntl(fd: 1</dev/pts/12>, arg: 10) = 10</dev/pts/12>

After:

 77059.513 ( 0.005 ms): bash/6649 fcntl(fd: 1</dev/pts/12>, cmd: DUPFD, arg: 10) = 10</dev/pts/12>

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-woois88uwcr4xu38xx1ihiwo@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-trace.c

index b842bd93457fbdba1662e00f7e0d6c64914c305d..bab87f612a361d6ea0e9216f291552aa53f713fe 100644 (file)
@@ -652,7 +652,8 @@ static struct syscall_fmt {
          .arg = { [0] = { .scnprintf = SCA_FDAT, /* fd */ }, }, },
        { .name     = "fcntl",      .errmsg = true,
          .arg = { [1] = { .scnprintf = SCA_FCNTL_CMD, /* cmd */
-                          .parm      = &strarrays__fcntl_cmds_arrays, /* cmd */ },
+                          .parm      = &strarrays__fcntl_cmds_arrays,
+                          .show_zero = true, },
                   [2] = { .scnprintf =  SCA_FCNTL_ARG, /* arg */ }, }, },
        { .name     = "fdatasync",  .errmsg = true, },
        { .name     = "flock",      .errmsg = true,