ipv4: Use return value of inet_iif() for __raw_v4_lookup in the while loop
authorStephen Suryaputra <ssuryaextr@gmail.com>
Tue, 25 Jun 2019 00:14:06 +0000 (20:14 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 25 Jun 2019 19:46:02 +0000 (12:46 -0700)
In commit 19e4e768064a8 ("ipv4: Fix raw socket lookup for local
traffic"), the dif argument to __raw_v4_lookup() is coming from the
returned value of inet_iif() but the change was done only for the first
lookup. Subsequent lookups in the while loop still use skb->dev->ifIndex.

Fixes: 19e4e768064a8 ("ipv4: Fix raw socket lookup for local traffic")
Signed-off-by: Stephen Suryaputra <ssuryaextr@gmail.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/raw.c

index 0b8e06ca75d6a5d836cdbd442f8a2e38995b19f9..40a6abbc9cf613ed1c180f8bae65a9713736dfdd 100644 (file)
@@ -197,7 +197,7 @@ static int raw_v4_input(struct sk_buff *skb, const struct iphdr *iph, int hash)
                }
                sk = __raw_v4_lookup(net, sk_next(sk), iph->protocol,
                                     iph->saddr, iph->daddr,
-                                    skb->dev->ifindex, sdif);
+                                    dif, sdif);
        }
 out:
        read_unlock(&raw_v4_hashinfo.lock);