ixgbe: Do not allow LRO or MTU change with XDP
authorTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 30 May 2018 23:14:23 +0000 (16:14 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Thu, 26 Jul 2018 16:04:05 +0000 (09:04 -0700)
XDP does not support jumbo frames or LRO.  These checks are being made
outside the driver when an XDP program is loaded, however, there is
nothing preventing these from changing after an XDP program is loaded.
Add the checks so that while an XDP program is loaded, do not allow MTU
to be changed or LRO to be enabled.

Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

index 5a6600f7b382c10e1e0d06ed5046dcc2a43e5cfe..c42256e9199710dc772f230da145a4b8cdac5f49 100644 (file)
@@ -6469,6 +6469,11 @@ static int ixgbe_change_mtu(struct net_device *netdev, int new_mtu)
 {
        struct ixgbe_adapter *adapter = netdev_priv(netdev);
 
+       if (adapter->xdp_prog) {
+               e_warn(probe, "MTU cannot be changed while XDP program is loaded\n");
+               return -EPERM;
+       }
+
        /*
         * For 82599EB we cannot allow legacy VFs to enable their receive
         * paths when MTU greater than 1500 is configured.  So display a
@@ -9407,6 +9412,11 @@ static netdev_features_t ixgbe_fix_features(struct net_device *netdev,
        if (!(adapter->flags2 & IXGBE_FLAG2_RSC_CAPABLE))
                features &= ~NETIF_F_LRO;
 
+       if (adapter->xdp_prog && (features & NETIF_F_LRO)) {
+               e_dev_err("LRO is not supported with XDP\n");
+               features &= ~NETIF_F_LRO;
+       }
+
        return features;
 }