staging: solo6010: fix signess bug
authorVasiliy Kulikov <segooon@gmail.com>
Sun, 12 Sep 2010 18:56:57 +0000 (22:56 +0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 16 Sep 2010 19:37:33 +0000 (12:37 -0700)
video_nr is unsigned, so check video_nr >= 0 doesn't make sense.
The only "negative" value may be -1, so explicitly check for it.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/solo6x10/solo6010-v4l2-enc.c
drivers/staging/solo6x10/solo6010-v4l2.c

index f114b4b7d8ee68211cd6e71065fdcc8877c4ef79..bbf3d9c4abb03aa6dc4b17f9e3f0d123cc7306d7 100644 (file)
@@ -1497,7 +1497,7 @@ static struct solo_enc_dev *solo_enc_alloc(struct solo6010_dev *solo_dev, u8 ch)
                 "%s-enc (%i/%i)", SOLO6010_NAME, solo_dev->vfd->num,
                 solo_enc->vfd->num);
 
-       if (video_nr >= 0)
+       if (video_nr != -1)
                video_nr++;
 
        spin_lock_init(&solo_enc->lock);
index 9537cc6ee3b704415f7d06cccc4e63c585148868..9731fa02b5e80702c380e42dfd57c996dad03a3e 100644 (file)
@@ -825,7 +825,7 @@ int solo_v4l2_init(struct solo6010_dev *solo_dev)
        snprintf(solo_dev->vfd->name, sizeof(solo_dev->vfd->name), "%s (%i)",
                 SOLO6010_NAME, solo_dev->vfd->num);
 
-       if (video_nr >= 0)
+       if (video_nr != -1)
                video_nr++;
 
        dev_info(&solo_dev->pdev->dev, "Display as /dev/video%d with "