net: dsa: remove switch routing table setup code
authorVivien Didelot <vivien.didelot@gmail.com>
Thu, 31 Oct 2019 02:09:15 +0000 (22:09 -0400)
committerDavid S. Miller <davem@davemloft.net>
Thu, 31 Oct 2019 21:26:38 +0000 (14:26 -0700)
The dsa_switch structure has no routing table specific data to setup,
so the switch fabric can directly walk its ports and initialize its
routing table from them.

This allows us to remove the dsa_switch_setup_routing_table function.

Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/dsa2.c

index efd7453f308ef53e24ba59cb4ee07f6c0726a803..a887231fff1316424c1624fc964fec2b075a069b 100644 (file)
@@ -176,14 +176,13 @@ static bool dsa_port_setup_routing_table(struct dsa_port *dp)
        return true;
 }
 
-static bool dsa_switch_setup_routing_table(struct dsa_switch *ds)
+static bool dsa_tree_setup_routing_table(struct dsa_switch_tree *dst)
 {
-       struct dsa_switch_tree *dst = ds->dst;
        bool complete = true;
        struct dsa_port *dp;
 
        list_for_each_entry(dp, &dst->ports, list) {
-               if (dp->ds == ds && dsa_port_is_dsa(dp)) {
+               if (dsa_port_is_dsa(dp)) {
                        complete = dsa_port_setup_routing_table(dp);
                        if (!complete)
                                break;
@@ -193,25 +192,6 @@ static bool dsa_switch_setup_routing_table(struct dsa_switch *ds)
        return complete;
 }
 
-static bool dsa_tree_setup_routing_table(struct dsa_switch_tree *dst)
-{
-       struct dsa_switch *ds;
-       bool complete = true;
-       int device;
-
-       for (device = 0; device < DSA_MAX_SWITCHES; device++) {
-               ds = dst->ds[device];
-               if (!ds)
-                       continue;
-
-               complete = dsa_switch_setup_routing_table(ds);
-               if (!complete)
-                       break;
-       }
-
-       return complete;
-}
-
 static struct dsa_port *dsa_tree_find_first_cpu(struct dsa_switch_tree *dst)
 {
        struct dsa_port *dp;