ASoC: SOF/Intel: fix selection of SND_INTEL_NHTL
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 29 Aug 2019 21:42:13 +0000 (16:42 -0500)
committerMark Brown <broonie@kernel.org>
Fri, 30 Aug 2019 11:26:53 +0000 (12:26 +0100)
We should only select SND_INTEL_NHLT when ACPI is defined. This was
done for the legacy HDAudio driver but not for DSP-enabled cases,
leading to compilation errors with randconfig.

Fix by aligning on the same solution.

For the Skylake driver this is overkill since there is a top-level
dependency on ACPI, but it doesn't hurt and it's better to have
consistency.

Fixes: 68b953aeb50d9 ('ASoC: SOF: Intel: hda: fixup HDaudio topology name with DMIC number')
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20190829214213.11653-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/Kconfig
sound/soc/sof/intel/Kconfig

index a3ec17fd63cdea4cf9cce9d0123710f9924ee216..01c99750212a22b0509c8b110757c119efe5301f 100644 (file)
@@ -215,7 +215,7 @@ config SND_SOC_INTEL_SKYLAKE_COMMON
        select SND_SOC_INTEL_SST
        select SND_SOC_HDAC_HDA if SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC
        select SND_SOC_ACPI_INTEL_MATCH
-       select SND_INTEL_NHLT
+       select SND_INTEL_NHLT if ACPI
        help
          If you have a Intel Skylake/Broxton/ApolloLake/KabyLake/
          GeminiLake or CannonLake platform with the DSP enabled in the BIOS
index 889b6202d054b071a5009924370484ba26c42911..479ba249e219af3ac4acbcd4f52622e51539d601 100644 (file)
@@ -286,7 +286,7 @@ config SND_SOC_SOF_HDA
        tristate
        select SND_HDA_EXT_CORE if SND_SOC_SOF_HDA_LINK
        select SND_SOC_HDAC_HDA if SND_SOC_SOF_HDA_AUDIO_CODEC
-       select SND_INTEL_NHLT
+       select SND_INTEL_NHLT if ACPI
        help
          This option is not user-selectable but automagically handled by
          'select' statements at a higher level