SUNRPC: Partial revert of commit 168e4b39d1afb79a7e3ea6c3bb246b4c82c6bdb9
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Fri, 4 Jan 2013 17:50:30 +0000 (12:50 -0500)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Fri, 4 Jan 2013 17:59:30 +0000 (12:59 -0500)
Partially revert commit (SUNRPC: add WARN_ON_ONCE for potential deadlock).
The looping behaviour has been tracked down to a knownn issue with
workqueues, and a workaround has now been implemented.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Weston Andros Adamson <dros@netapp.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Bruce Fields <bfields@fieldses.org>
Cc: stable@vger.kernel.org [>= 3.7]
net/sunrpc/clnt.c

index 822f020fa7f458e07a8e216e6609447daefb8747..1915ffe598e3faf6e0aff577f530fab85106c7c4 100644 (file)
@@ -610,11 +610,6 @@ EXPORT_SYMBOL_GPL(rpc_killall_tasks);
  */
 void rpc_shutdown_client(struct rpc_clnt *clnt)
 {
-       /*
-        * To avoid deadlock, never call rpc_shutdown_client from a
-        * workqueue context!
-        */
-       WARN_ON_ONCE(current->flags & PF_WQ_WORKER);
        might_sleep();
 
        dprintk_rcu("RPC:       shutting down %s client for %s\n",