PCI: endpoint: Fix find_first_zero_bit() usage

find_first_zero_bit()'s parameter 'size' is defined in bits,
not in bytes.

Calling find_first_zero_bit() with the wrong size unit
will lead to insidious bugs.

Fix this by calling find_first_zero_bit() with size BITS_PER_LONG,
rather than sizeof() and add missing find_first_zero_bit() return
handling.

Fixes: d74679911610 ("PCI: endpoint: Introduce configfs entry for configuring EP functions")
Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>

diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c
index e8f65eb51c1a605cf57e4cae945f37a2173767e6..c9a2fb9dd49d97965f368560d85a9a22fbafa533 100644 (file)
--- a/drivers/pci/endpoint/pci-ep-cfs.c
+++ b/drivers/pci/endpoint/pci-ep-cfs.c
@@ -103,7 +103,10 @@ static int pci_epc_epf_link(struct config_item *epc_item,
        struct pci_epf *epf = epf_group->epf;
 
        func_no = find_first_zero_bit(&epc_group->function_num_map,
-                                     sizeof(epc_group->function_num_map));
+                                     BITS_PER_LONG);
+       if (func_no >= BITS_PER_LONG)
+               return -EINVAL;
+
        set_bit(func_no, &epc_group->function_num_map);
        epf->func_no = func_no;